Skip to content

Add GetWorkflowRunAttempt#2290

Merged
gmlewis merged 3 commits into
google:masterfrom
reeves122:feature/issue-2287-get-workflow-run-attempt
Feb 14, 2022
Merged

Add GetWorkflowRunAttempt#2290
gmlewis merged 3 commits into
google:masterfrom
reeves122:feature/issue-2287-get-workflow-run-attempt

Conversation

@reeves122

@reeves122 reeves122 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

Fixes: #2287

@codecov

codecov Bot commented Feb 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2290 (40c8110) into master (2be8000) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2290   +/-   ##
=======================================
  Coverage   97.83%   97.84%           
=======================================
  Files         115      115           
  Lines       10360    10378   +18     
=======================================
+ Hits        10136    10154   +18     
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/actions_workflow_runs.go 100.00% <100.00%> (ø)
github/event.go 100.00% <0.00%> (ø)
github/messages.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be8000...40c8110. Read the comment docs.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reeves122 !
Just one tweak, please.

Comment thread github/actions_workflow_runs.go Outdated
@gmlewis

gmlewis commented Feb 14, 2022

Copy link
Copy Markdown
Collaborator

You will now need to run go generate ./... and push the changes to this PR.
See CONTRIBUTING.md for details.

@gmlewis

gmlewis commented Feb 14, 2022

Copy link
Copy Markdown
Collaborator

Thank you for the review, @jeremiah-norris-champ !

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @reeves122 !
LGTM.
Merging.

@gmlewis gmlewis merged commit 2981e4f into google:master Feb 14, 2022
jlaportebot added a commit to jlaportebot/go-github that referenced this pull request Jun 28, 2026
* Add GetWorkflowRunAttempt

* Use pointer for bool in ExcludePullRequests for WorkflowRunAttemptOptions

* Add GetExcludePullRequests from go generate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for getting a workflow run attempt

3 participants