Support deployment protection rule event type#2773
Conversation
This commit adds the deployment_protection_rule event type to the list of parseable event types
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report
@@ Coverage Diff @@
## master #2773 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 132 132
Lines 11638 11640 +2
=======================================
+ Hits 11412 11414 +2
Misses 154 154
Partials 72 72
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @BoyangHuang !
After a few tweaks, we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Thanks for catching all of my misses. Much appreciated :) I'll run a follow-up `go generate` command after committing your suggestions. Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Thank you @gmlewis for catching my mistakes :) much appreciated |
|
Sorry, I forgot to mention that you will need to |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @BoyangHuang !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
small bump here - is there any contributor available to give this a quick look? Thank you! |
|
Hi @valbeat - do you have time for a code review? |
|
Thank you, @valbeat ! |
This commit adds the deployment_protection_rule event type to the list of parseable event types
Fixes: #2774.