Skip to content

fix missing collections.abc.Mapping inheritance for class ConfigDict - #46

Open
DrPlantabyte wants to merge 3 commits into
google:masterfrom
DrPlantabyte:master
Open

fix missing collections.abc.Mapping inheritance for class ConfigDict#46
DrPlantabyte wants to merge 3 commits into
google:masterfrom
DrPlantabyte:master

Conversation

@DrPlantabyte

@DrPlantabyte DrPlantabyte commented Feb 10, 2025

Copy link
Copy Markdown

This PR makes class ConfigDict inherit Python built-in abstract base class collections.abc.Mapping so that isinstance(config_dict_obj, collections.abc.Mapping) returns True, conforming with Python collection type conventions.

See issue #47

@google-cla

google-cla Bot commented Feb 10, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DrPlantabyte

DrPlantabyte commented Feb 10, 2025

Copy link
Copy Markdown
Author

I've now signed the Google CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant