pybind: Add S2Point bindings - #524
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Looks like a good start. I'll have a closer look tomorrow. How much are you planning on wrapping? |
Great!
For my purposes I mainly need S2Cell and its dependencies. But I'm happy to do more to get this to whatever you would consider a viable MVP. Open to suggestions there? |
6535f67 to
7b92d38
Compare
|
@jmr, I made most of the changes you suggested. Let me know what you prefer for the directory layout and how to organize the python modules and I'll make those changes as well. |
|
@jmr, friendly ping? I'm looking for feedback on the directory layout and python modules (see above). |
|
@jmr, I've flattened the directories and responded to your other comments. This should be ready for another round! (Still waiting on the lawyers to sign that CLA...) |
be83d9c to
f09da06
Compare
Done! |
|
@jmr, I've made those changes. I also squashed all the commits to use my corp email from the CONTRIBUTORS files. |
|
If I "squash and merge", it's only letting me use the noreply@github address. I assume you want the address from https://github.com/deustis/s2geometry/commit/f09da0646a6844c71441a1c73f5c4a433bd12fc6.patch. Can you expand the commit message a bit? Here's what I had, feel free to change it. I think then I can "rebase and merge". |
Add pybind11 bindings for S2Point and bazel config. This is the first step towards google#522 (pybind11 wrapper)
f09da06 to
2b7ddcf
Compare
|
I've updated the commit description! For the email address, I don't have a strong preference. I believe the CLA is satisfied either way. If you can carry through the aurora.tech email that would be slightly preferable but if not the noreply email address is okay too. |
|
Thanks! |
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Add pybind11 bindings for S1Interval. Also add interface notes to the python README
Add pybind11 bindings for S1Interval. Also add interface notes to the python README. (Part of a series of addressing #524.)
Merge branch 'master' into deustis/r2_bindings. Add pybind11 bindings for R1Interval, R2Point, and R2Rect. (Part of a series of addressing google#524.)
Initial Bazel configuration for Pybind11 and S2Point bindings.
#522
The S2 Geometry library is transitioning from SWIG-based bindings to pybind11-based bindings.
During this migration:
s2geometry): The current production bindings, built with CMake. Useimport s2geometryto access these.s2geometry_pybind): The new bindings under development, built with Bazel. Useimport s2geometry_pybindto access these.Once the pybind11 bindings are feature-complete and stable, the SWIG bindings will be deprecated and the pybind11 package will be renamed to
s2geometryto become the primary Python API.This PR adds Bazel configuration for building and testing the bindings on the local toolchain. For distribution we'll need to generate a wheel for compatibility with different OS and python versions.