Fix encode() with an empty batch and out_type='offset_mapping' - #1320
Merged
taku910 merged 2 commits intoSep 8, 2026
Merged
Conversation
The default return_bytes expression short-circuits to the input list itself rather than to False, so an empty batch passes [] into the bool parameter of _EncodeAsOffsetMappingBatch and pybind11 raises TypeError. Every other return_type gives [] for an empty batch.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Updated test_offset_mapping_empty_batch - uses self.sp_ - add more test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sp.encode([], out_type='offset_mapping')raisesTypeError. Every other return typegives
[]for an empty batch.The default
return_bytesexpression isWith
input == []theandchain short-circuits on the empty list, so the wholeexpression evaluates to
[]rather thanFalse. That[]is appended toargsandpassed to the pybind11
boolparameter, which rejects it.Wrapping the second operand in
bool()fixes it. Byte detection is unchanged: a bytesbatch still returns bytes pieces and a str batch still returns str pieces.
One regression test added, covering
offset_mappingalongsideintandstrso theempty-batch behavior stays consistent. It fails before and passes after.
python/test/sentencepiece_test.pygoes from 38 passed to 39 with the same 6pre-existing failures, which need a locally built extension and are unrelated.