You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, this dep is only in devDependencies atm. OpenCensus or OpenTelemetry are providers for tracestate/traceparent, so the dependency should be optional and only crash if the user passes tracestate/traceparent in their config.
Repro:
$ npm init -y
$ npm install @google-cloud/sqlcommenter-knex
$ node -i "require('@google-cloud/sqlcommenter-knex')"internal/modules/cjs/loader.js:968 throw err; ^Error: Cannot find module '/usr/local/google/home/aaronabbott/repo/sqlcommenter/nodejs/sqlcommenter-nodejs/samples/express-opentelemetry/require('@google-cloud/sqlcommenter-knex')' at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15) at Function.Module._load (internal/modules/cjs/loader.js:841:27) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) at internal/main/run_main_module.js:17:47 { code: 'MODULE_NOT_FOUND', requireStack: []}
index.js(for both knex and sequelize integration) requiresutil.jswhich requires@opencensus/propagation-tracecontext.sqlcommenter/nodejs/sqlcommenter-nodejs/packages/sqlcommenter-knex/util.js
Line 15 in 5adcedb
However, this dep is only in devDependencies atm. OpenCensus or OpenTelemetry are providers for tracestate/traceparent, so the dependency should be optional and only crash if the user passes tracestate/traceparent in their config.
Repro: