Re-Added Unhandled Exception Handling - #1005
Merged
aomarks merged 5 commits intoJan 10, 2024
Merged
Conversation
In #471 the handling of unhandled exceptions was removed. This adds back the missing handling so that we can gracefully deal with internal exceptions thrown during execution.
Contributor
Author
aomarks
requested changes
Jan 9, 2024
aomarks
left a comment
Member
There was a problem hiding this comment.
Looks good! Mind just adding a changelog entry for this?
Member
|
Also needs an |
aomarks
approved these changes
Jan 10, 2024
aomarks
enabled auto-merge (squash)
January 10, 2024 00:14
Member
I added these, merging 👍 |
Contributor
Author
|
Thanks @aomarks, I missed the changelog and am too used to the Prettier ESLint plugin 😄 Odd looking test failure though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #471 the handling of unhandled exceptions was removed. This adds that missing handling back so that any exceptions that aren't caught can be gracefully handled and raised to the user correctly.