Conversation
rictic
left a comment
There was a problem hiding this comment.
Nice design
I can imagine potential improvements, like a way for wireit to communicate with a running service process (to indicate things like when the service is ready, etc), but those would be optional if added, and they might not be worth the complexity
| "type": "array" | ||
| }, | ||
| "service": { | ||
| "markdownDescription": "If true, treat this script as a long-running process.\nServices are automatically brought up and down as they depended upon by other scripts. If invoked directly, services continue running until Wireit is killed with Ctrl-C.\nFor more info, see: https://github.com/google/wireit#services", |
There was a problem hiding this comment.
as they depended upon -> as they are depended upon
Yeah -- I think we probably should include a |
First of a series of PRs to implement services.
This just documents the feature and adds the config field.
Note this PR is merging into the
servicebranch, where I'll be staging this feature until everything is ready (in case we need to release something in the meantime).