Use AlignmentError in Unalign's failure conditions - #1198
Merged
Conversation
joshlf
requested changes
May 6, 2024
| I: Invariants, | ||
| { | ||
| /// Converts a `Ptr` to a `Unalign<T>` into an `Ptr` to an unaligned `T`. | ||
| pub(crate) fn into_unaligned( |
Member
There was a problem hiding this comment.
Suggested change
| pub(crate) fn into_unaligned( | |
| pub(crate) fn into_unalign( |
| } | ||
| } | ||
|
|
||
| impl<'a, T, I> Ptr<'a, T, I> |
Member
There was a problem hiding this comment.
Fancy doc comment here with the UTF-8 arrow character?
| where | ||
| I: Invariants, | ||
| { | ||
| /// Converts a `Ptr` to a `Unalign<T>` into an `Ptr` to an unaligned `T`. |
Member
There was a problem hiding this comment.
Suggested change
| /// Converts a `Ptr` to a `Unalign<T>` into an `Ptr` to an unaligned `T`. | |
| /// Converts an unaligned `Ptr<T>` to an aligned `Ptr<Unalign<T>>`. |
joshlf
approved these changes
May 6, 2024
joshlf
left a comment
Member
There was a problem hiding this comment.
Please fix the outstanding comments, but feel free to merge after that.
This make's `Unalign`'s methods consistent with zerocopy's other methods, and, in the case of `Unalign::try_deref_mut`, allows the original `&mut Unalign<T>` to be reused in the event of failure. Makes progress towards #1139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make's
Unalign's methods consistent with zerocopy's other methods, and, in the case ofUnalign::try_deref_mut, allows the original&mut Unalign<T>to be reused in the event of failure.Makes progress towards #1139