ci: update fedora latest to 44#16249
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Fedora base image version from 40 to 44 in the Bazel and CMake Dockerfiles. However, Fedora 44 is not a released version, which will cause the Docker builds to fail. The reviewer recommends using the latest stable version (Fedora 41) and defining the version string with an ARG to improve maintainability across files.
| # limitations under the License. | ||
|
|
||
| FROM fedora:40 | ||
| FROM fedora:44 |
There was a problem hiding this comment.
Fedora 44 is not a released version (the current latest stable version is Fedora 41). Using a non-existent version will cause the Docker build to fail. Additionally, use an ARG to define version strings that are duplicated across multiple files to improve maintainability.
ARG FEDORA_VERSION=41
FROM fedora:${FEDORA_VERSION}
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
| # limitations under the License. | ||
|
|
||
| FROM fedora:40 | ||
| FROM fedora:44 |
There was a problem hiding this comment.
Fedora 44 is not a released version (the current latest stable version is Fedora 41). Using a non-existent version will cause the Docker build to fail. Additionally, use an ARG to define version strings that are duplicated across multiple files to improve maintainability.
ARG FEDORA_VERSION=41
FROM fedora:${FEDORA_VERSION}
References
- In Dockerfiles, use
ARGto define version strings that are duplicated across multiple files to improve maintainability.
No description provided.