Skip to content

Eliminate all transitive guava-jdk5 dependencies #2918

Closed
Closed
Eliminate all transitive guava-jdk5 dependencies#2918
Assignees
chingor13
Labels
dependenciesstatus: blockedResolving the issue is dependent on other work.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@jbaldassari
jbaldassari
opened on Feb 17, 2018

Google Cloud dependencies are pulling in multiple incompatible versions of Guava. Most depend on newer versions of Guava like com.google.guava:guava:20, but others are pulling in com.google.guava:guava-jdk5:17.0. When I miss excluding that ancient jdk5 version from somewhere I end up with a bunch of classloader issues like:

java.lang.NoSuchMethodError: com.google.common.base.Preconditions.checkArgument(ZLjava/lang/String;J)V

For some reason I see this mostly with Cloud KMS (com.google.apis:google-api-services-cloudkms), but it actually appears to be coming from com.google.api-client:google-api-client:1.23.0. See http://mvnrepository.com/artifact/com.google.api-client/google-api-client/1.23.0 for example.

I'd be happy to contribute a PR myself, but I can't seem to find the right repo.

Activity

  1. garrettjonesgoogle commented on Feb 17, 2018

    @garrettjonesgoogle
    garrettjonesgoogle
    on Feb 17, 2018
    Contributor

    This has been done in code (googleapis/google-api-java-client@1b35470) but hasn't been released yet from google-api-java-client.

  2. jbaldassari commented on Feb 17, 2018

    @jbaldassari
    jbaldassari
    on Feb 17, 2018
    Author

    Great to hear! Thanks for the quick reply.

  3. pongad
    added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    status: blockedResolving the issue is dependent on other work.
    dependencies
    on Feb 18, 2018

  4. pongad commented on Feb 18, 2018

    @pongad
    pongad
    on Feb 18, 2018
    Contributor

    I'll add the "blocked" status since we're waiting for release.

  5. chingor13 commented on Oct 9, 2018

    @chingor13
    chingor13
    on Oct 9, 2018
    Contributor

    The google-api-java-client fix is out in 1.24.1.

  6. chingor13
    closed this as completedon Oct 9, 2018
  7. JustinBeckwith
    assigned
    chingor13
    on Feb 1, 2021
  8. chingor13
    added a commit that references this issue on Mar 24, 2026

    chore(main): release 6.60.1 (#2918)

    81293aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

dependenciesstatus: blockedResolving the issue is dependent on other work.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions