Skip to content

Fix Metric.update and add snippets for Metric class#1221

Merged
mziccard merged 3 commits into
googleapis:masterfrom
mziccard:metric-snippets
Sep 2, 2016
Merged

Fix Metric.update and add snippets for Metric class#1221
mziccard merged 3 commits into
googleapis:masterfrom
mziccard:metric-snippets

Conversation

@mziccard

@mziccard mziccard commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

This PR does the following:

  • Fix Metric.update: remove unnecessary MetricInfo parameter for Metric.update(Async)
  • Update snippets script to support method parameters with the final modifier
  • Add snippets to Metric's javadoc, MetricSnippets class and tests

@mziccard mziccard added docs api: logging Issues related to the Cloud Logging API. labels Sep 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@coveralls

coveralls commented Sep 1, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.005%) to 85.197% when pulling 1f16609 on mziccard:metric-snippets into 7309be5 on GoogleCloudPlatform:master.

@mziccard

mziccard commented Sep 1, 2016

Copy link
Copy Markdown
Contributor Author

/cc @lesv

lesv
lesv reviewed Sep 1, 2016
View reviewed changes
Comment thread ...oud-examples/src/test/java/com/google/cloud/examples/logging/snippets/ITLoggingSnippets.java
@@ -45,11 +46,11 @@ public class ITLoggingSnippets {
private static final String DATASET = "dataset";
private static final Set<String> DESCRIPTOR_TYPES = ImmutableSet.of("gce_instance", "gae_app",

This comment was marked as spam.

Sign in to view

@lesv

lesv commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

LGTM - I don't think my comment is actionable in a way that makes sense.

@mziccard mziccard merged commit 24c91c0 into googleapis:master Sep 2, 2016
@mziccard mziccard mentioned this pull request Sep 8, 2016
Closed
github-actions Bot pushed a commit that referenced this pull request Aug 24, 2022
@release-please
chore(main): release 2.3.5 (#1221)
da7f5cc 
🤖 I have created a release *beep* *boop*
---


## [2.3.5](googleapis/java-automl@v2.3.4...v2.3.5) (2022-08-24)


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1220](googleapis/java-automl#1220)) ([7ae87b9](googleapis/java-automl@7ae87b9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.13.5 (#1221)
1b01f94 
🤖 I have created a release *beep* *boop*
---


## [3.13.5](https://togithub.com/googleapis/java-logging/compare/v3.13.4...v3.13.5) (2022-12-06)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#1219](https://togithub.com/googleapis/java-logging/issues/1219)) ([b54e015](https://togithub.com/googleapis/java-logging/commit/b54e015b13b52bfae0f57242a08c452a74cbfb29))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@release-please
chore(main): release 0.130.29-alpha-SNAPSHOT (#1221)
f94cec7 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@gcf-owl-bot
chore: bump urllib3 from 1.26.17 to 1.26.18 in /synthtool/gcp/templat…
acfc89d 
…es/java_library/.kokoro (#1885) (#1221)

Source-Link: googleapis/synthtool@e4a9d44
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:4875b2142cb4325542ba4f3175a81921c4b2b8256db012b220e3ca9637b34154

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@release-please
chore(main): release 1.18.0 (#1221)
24ef147 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@release-please
chore(main): release 3.13.5 (googleapis#1221)
d16e1bc 
🤖 I have created a release *beep* *boop*
---


## [3.13.5](https://togithub.com/googleapis/java-logging/compare/v3.13.4...v3.13.5) (2022-12-06)


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([googleapis#1219](https://togithub.com/googleapis/java-logging/issues/1219)) ([d67fb04](https://togithub.com/googleapis/java-logging/commit/d67fb04a4ccd60933a020a03494488386416bd77))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@release-please
chore(main): release 1.18.0 (#1221)
fe857e1 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
4294dde 
…19.0 (#1221)
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
8ec7d17 
…19.0 (#1221)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@release-please
chore(main): release 1.120.8-SNAPSHOT (#1221)
5bd861f 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
@release-please
chore(main): release 1.120.8-SNAPSHOT (#1221)
42559b2 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
6eb08f0 
…cies to v2.10.0 (googleapis#1221)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.9.0` -> `2.10.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/compatibility-slim/2.9.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.10.0/confidence-slim/2.9.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v2.10.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#&#8203;2100-httpsgithubcomgoogleapisjava-shared-dependenciescomparev290v2100-2022-04-15)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.9.0...v2.10.0)

##### Dependencies

-   google-cloud-core 2.6.0 ([#&googleapis#8203;668](https://togithub.com/googleapis/java-shared-dependencies/issues/668)) ([22f4d18](https://togithub.com/googleapis/java-shared-dependencies/commit/22f4d1809cbb9848174b3569ab527e4bef00d443))
-   reverting protobuf to 3.19.4 ([#&googleapis#8203;657](https://togithub.com/googleapis/java-shared-dependencies/issues/657)) ([8501e6d](https://togithub.com/googleapis/java-shared-dependencies/commit/8501e6d842c10d2370bbd5d5246070134336bddd))
-   update dependency com.fasterxml.jackson:jackson-bom to v2.13.2.20220328 ([#&googleapis#8203;646](https://togithub.com/googleapis/java-shared-dependencies/issues/646)) ([7bfd6d7](https://togithub.com/googleapis/java-shared-dependencies/commit/7bfd6d7073859d1955b91b368c6713a72ffa14b6))
-   update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#&googleapis#8203;662](https://togithub.com/googleapis/java-shared-dependencies/issues/662)) ([1b8e378](https://togithub.com/googleapis/java-shared-dependencies/commit/1b8e378fe0ccf2a28c759868caaf5ba593a95728))
-   update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#&googleapis#8203;652](https://togithub.com/googleapis/java-shared-dependencies/issues/652)) ([1cc80ee](https://togithub.com/googleapis/java-shared-dependencies/commit/1cc80ee984ebcad9bc2a95e2f28c0a49fe924b37))
-   update dependency com.google.errorprone:error_prone_annotations to v2.13.0 ([#&googleapis#8203;669](https://togithub.com/googleapis/java-shared-dependencies/issues/669)) ([61b7834](https://togithub.com/googleapis/java-shared-dependencies/commit/61b78341b34a251722be4805a6bdd895cd64836c))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#&googleapis#8203;654](https://togithub.com/googleapis/java-shared-dependencies/issues/654)) ([140ef40](https://togithub.com/googleapis/java-shared-dependencies/commit/140ef405bc17ed83f5ce177df59affca14fbe49c))
-   update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#&googleapis#8203;658](https://togithub.com/googleapis/java-shared-dependencies/issues/658)) ([f6f93e5](https://togithub.com/googleapis/java-shared-dependencies/commit/f6f93e5b9172c9684623c4c148e4a8fe2fae1e94))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.2 ([#&googleapis#8203;655](https://togithub.com/googleapis/java-shared-dependencies/issues/655)) ([20cd9ed](https://togithub.com/googleapis/java-shared-dependencies/commit/20cd9eda112c96836a5ab7485a4247ed2bc0edb8))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.33.3 ([#&googleapis#8203;663](https://togithub.com/googleapis/java-shared-dependencies/issues/663)) ([f011a46](https://togithub.com/googleapis/java-shared-dependencies/commit/f011a46c551dba16851b4f8c919c40452fc5d5c3))
-   update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#&googleapis#8203;651](https://togithub.com/googleapis/java-shared-dependencies/issues/651)) ([ad2ff73](https://togithub.com/googleapis/java-shared-dependencies/commit/ad2ff73207dd6493321c77d8eca0022baf13b4ce))
-   update dependency io.grpc:grpc-bom to v1.45.1 ([#&googleapis#8203;647](https://togithub.com/googleapis/java-shared-dependencies/issues/647)) ([38e46fc](https://togithub.com/googleapis/java-shared-dependencies/commit/38e46fc4f03af0a02f30ce4a2fa222c71797ae15))
-   update dependency org.checkerframework:checker-qual to v3.21.4 ([#&googleapis#8203;650](https://togithub.com/googleapis/java-shared-dependencies/issues/650)) ([125e80a](https://togithub.com/googleapis/java-shared-dependencies/commit/125e80ab2c3225a00c03f5ff5de94872ebb94303))
-   update gax.version to v2.15.0 ([#&googleapis#8203;649](https://togithub.com/googleapis/java-shared-dependencies/issues/649)) ([c7f32a6](https://togithub.com/googleapis/java-shared-dependencies/commit/c7f32a68b14520104432282ac9598643700162eb))
-   update gax.version to v2.16.0 ([#&googleapis#8203;664](https://togithub.com/googleapis/java-shared-dependencies/issues/664)) ([caaf941](https://togithub.com/googleapis/java-shared-dependencies/commit/caaf941643af04295f5527a0144587d7bf040862))
-   update google.common-protos.version to v2.8.1 ([#&googleapis#8203;656](https://togithub.com/googleapis/java-shared-dependencies/issues/656)) ([df4a4a2](https://togithub.com/googleapis/java-shared-dependencies/commit/df4a4a2130a3cdb2965ea42962d1ea6a85506ba7))
-   update google.common-protos.version to v2.8.2 ([#&googleapis#8203;659](https://togithub.com/googleapis/java-shared-dependencies/issues/659)) ([b499e2b](https://togithub.com/googleapis/java-shared-dependencies/commit/b499e2bc99506d48d26e35bf6e68c09409ce8b11))
-   update google.common-protos.version to v2.8.3 ([#&googleapis#8203;660](https://togithub.com/googleapis/java-shared-dependencies/issues/660)) ([461081c](https://togithub.com/googleapis/java-shared-dependencies/commit/461081c0cf73057c1f6e07fc573453ad467a60ae))
-   update iam.version to v1.3.0 ([#&googleapis#8203;648](https://togithub.com/googleapis/java-shared-dependencies/issues/648)) ([6670c4f](https://togithub.com/googleapis/java-shared-dependencies/commit/6670c4f61fcf075c543bfd148eea49796e0662ce))
-   update iam.version to v1.3.1 ([#&googleapis#8203;661](https://togithub.com/googleapis/java-shared-dependencies/issues/661)) ([cc8fbe6](https://togithub.com/googleapis/java-shared-dependencies/commit/cc8fbe6eae03341c2ece7d3356febc843a74a812))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable).
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@release-please
chore(main): release 2.6.2 (googleapis#1223)
0a13593 
🤖 I have created a release *beep* *boop*
---


### [2.6.2](googleapis/java-bigtable@v2.6.1...v2.6.2) (2022-04-15)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([googleapis#1221](googleapis/java-bigtable#1221)) ([6eb08f0](googleapis/java-bigtable@6eb08f0))
* update dependency com.google.cloud:native-image-support to v0.13.1 ([googleapis#1222](googleapis/java-bigtable#1222)) ([0437988](googleapis/java-bigtable@0437988))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mziccard @coveralls @lesv @googlebot