Skip to content

bigquery: table#insertHandler() document is wrong #336

Description

@hakobera

In table#insertHander(err, insertErrors) document, insertErrors[] has errors property.

https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/bigquery/table.js#L727-L728

But actually it has error not errors.

https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/bigquery/table.js#L755

Which is correct spec? document or implementation?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

🚨This issue needs some love.api: bigqueryIssues related to the BigQuery API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions