Skip to content

Storage "Interface Driven Design" Document#761

Closed
dhermes wants to merge 4 commits into
googleapis:masterfrom
dhermes:storage-surface-doc
Closed

Storage "Interface Driven Design" Document#761
dhermes wants to merge 4 commits into
googleapis:masterfrom
dhermes:storage-surface-doc

Conversation

@dhermes

@dhermes dhermes commented Mar 25, 2015

Copy link
Copy Markdown
Contributor

Still in flux (as of filing).

Follow along changes in:
www.googledrive.com/host/0B8el7dRo8mVOMk1HbFk4TVhDaEE

/cc @jgeewax @tseaver I'll ping Travis when it is complete.

UPDATE (March 30): @thobrla PTAL. @jgeewax asked me to design the final state of the desired surface area (all inspired by your bug #545). Our current code uses projection=noAcl to avoid loading ACL info with other metadata, while this hypothetical design ditches that concept.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2015
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling b725d9f on dhermes:storage-surface-doc into d34a15e on GoogleCloudPlatform:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 73d60b7 on dhermes:storage-surface-doc into d34a15e on GoogleCloudPlatform:master.

@dhermes

dhermes commented Mar 26, 2015

Copy link
Copy Markdown
Contributor Author

UPDATE: I have added everything except ACL sections. What a doozy! Please start reviewing. (I'm going to hold off on cc'ing Travis until I finish the ACL part.)

It's encouraged me to just throw away a few methods (e.g. Blob.rename()) and to make some protected to avoid distracting users.

Comment thread docs/storage-surface.rst Outdated

This comment was marked as spam.

This comment was marked as spam.

@dhermes

dhermes commented Mar 27, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver All the comments without response I plan on addressing. I am away from keyboard today and will get to them tomorrow (March 28, 2015).

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 2a1eab6 on dhermes:storage-surface-doc into 4785201 on GoogleCloudPlatform:master.

@dhermes dhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 30, 2015
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling d84dc38 on dhermes:storage-surface-doc into 4785201 on GoogleCloudPlatform:master.

@dhermes

dhermes commented Mar 30, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver I have added ACL stuff and changed around a few of the things you already reviewed.

Comment thread docs/storage-surface.rst

This comment was marked as spam.

Comment thread docs/storage-surface.rst

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes force-pushed the storage-surface-doc branch from d84dc38 to ca5122d Compare January 25, 2016 19:39
@dhermes dhermes closed this Jan 26, 2016
@dhermes dhermes deleted the storage-surface-doc branch January 26, 2016 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants