Feature suggestion: auto content-type on blob creation

[niclarcipretti]

What if the API saves the blob setting it's content-type automatically? I guess it would make sense at least for public blobs. Do you have an opinion on that?

Cheers

[chingor13]

I assume you mean that we would try to detect the file type and automatically set the Content-type metadata for the blob.

On the client side, we don't do this for developers because there are several different ways to accomplish in Java (extension, magic bytes) this with pros/cons for each method. We don't want to dictate how or whether to automatically detect the mime type so it's left to developers to do. You can do a quick Google search for "java file mime type" for several methods of detecting the mime type.

If you'd like to file a feature request against the actual backend API, you can file an issue against the service: https://issuetracker.google.com/issues/new?component=187243&template=0

[andrey-qlogic]

@chingor13 , is there any update on this feature request?

[dhoard]

@chingor13 thoughts on providing a setContentTypeMapping(Map<String, String> map) on StorageOptions.Builder to setup an blob name extension to content-type mapping?

It would be completely optional and shouldn't breaking any existing code.

[andrey-qlogic]

@chingor13 , @dhoard
I would assume that we can add something like the example below
similar to https://github.com/googleapis/google-cloud-java/blob/35cc9874ce2963ca9d66aa0d584208a59154b6f3/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java#L611

public final String getContentType() {
    if (headerProvider != null) {
      for (Map.Entry<String, String> entry : headerProvider.getHeaders().entrySet()) {
        if ("content-type".equals(entry.getKey().toLowerCase())) {
          return entry.getValue();
        }
      }
    }
    return null;
  }

[dhoard]

@andrey-qlogic conceptually that might work. From an implementation standpoint, it would be better to perform a get() on the headerProvider ...

public final String getContentType() {
    String contentType = null;

    if (headerProvider != null) {
        contentType = headerProvider.get("content-type");
    }

    return contentType;
}

@chingor13 your feedback?

[dmitry-fa]

Similar fix in nodejs: googleapis/nodejs-storage#1190