[fea-rs] Move some predicate tests to be file-based - #2099
Merged
Conversation
These tests were jumping through hoops to check error conditions, and we have a very nice pattern for exactly that.
anthrotype
approved these changes
Aug 28, 2026
anthrotype
left a comment
Member
There was a problem hiding this comment.
LGTM
Nit: the old test also asserted that these predicates fail during validation. The shared bad-test harness accepts CompilationFail too, so that specific invariant is no longer covered. Not sure if we should bother retaining a small assertion for that? Up to you
Member
Author
|
To my mind the distinction between the validation and compilation passes are opaque to the consumer, as long as we're showing a meaningful error I think it's okay? |
Member
|
ok yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were jumping through hoops to check error conditions, and we have a very nice pattern for exactly that.
JMM