fix: replace testConnection 30s cooldown with cancel-and-restart - #34
Open
eerenyuan wants to merge 1 commit into
Open
fix: replace testConnection 30s cooldown with cancel-and-restart#34eerenyuan wants to merge 1 commit into
eerenyuan wants to merge 1 commit into
Conversation
grapeot
added a commit
that referenced
this pull request
Jun 3, 2026
…tor networking, send verify) These are pitfalls hit during real-device runs, not predictions: Test Connection can wedge into an infinite spinner if re-tapped within a session (force-stop + clear-data to recover; cf #34); emulator->host can drop (connected:False despite a healthy host); and send-prompt's reliability comes from dismiss-keyboard + post-send verify/retry. Keeps the skill honest about what is and isn't solid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testConnection()with a cancel-and-restart mechanism. Previously, callingtestConnection()within 30s of a previous call was silently ignored, which caused: (1) the Settings spinner to get stuck permanently, (2) Test Connection having no response before Save, (3) repeated URL changes not taking effect.launchConnectionTest()now returns aJobso the previous test can be cancelled before starting a new one.