Fix WASM memory allocation - #1154
Merged
Merged
Conversation
Contributor
|
@leoyvens Can we move that explanation into the commit message? |
Jannis
approved these changes
Sep 3, 2019
Contributor
Author
|
@Jannis oops. It was originally in the commit message, I lost it somehow and then re-wrote in the PR description. Now it's merged, oh well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1145 made the assumption that two consecutive
memory.allocatecalls would allocate contiguous memory. This is of course false if AS allocated any memory for itself between the calls. This would cause memory corruption on handlers that did a lot of things and needed to callmemory.allocatemore than once inraw_new. This was the case with the Betoken subgraph, I reproduced the error locally and verified that this PR fixes it.