Conversation
Use the `dep?/feature` weak-dependency syntax so that enabling `async` or `sync` only propagates the feature flag to service crates that are already pulled in by their own feature (e.g. `identity`). Previously `dep-name/feature` implicitly enabled every optional service dependency, meaning `async + identity` would compile all service crates. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
dep?/featureweak-dependency syntax so that enablingasyncorsynconly propagates the feature flag to service crates that are already pulled in by their own feature (e.g.identity). Previouslydep-name/featureimplicitly enabled every optional service dependency, meaningasync + identitywould compile all service crates.Assisted-by: Claude noreply@anthropic.com