Conversation
AsyncOpenStack clones share one Arc<RwLock<SessionContext>>, so concurrent requests hitting 401 each ran their own clear_all_auth + full re-auth independently. Under an interactive AuthHelper this meant up to N credential prompts and N parallel Keystone logins for one token expiry. Add reauth_lock (tokio::sync::Mutex) shared across clones, and auth_generation on SessionContext bumped in set_auth. Waiters that acquire the lock after another task already re-authed recheck the generation and skip redundant work instead of re-authing again. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncOpenStack clones share one Arc<RwLock>, so
concurrent requests hitting 401 each ran their own clear_all_auth +
full re-auth independently. Under an interactive AuthHelper this
meant up to N credential prompts and N parallel Keystone logins for
one token expiry.
Add reauth_lock (tokio::sync::Mutex) shared across clones, and
auth_generation on SessionContext bumped in set_auth. Waiters that
acquire the lock after another task already re-authed recheck the
generation and skip redundant work instead of re-authing again.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com