fix(sdk): Call anchor_plugins() unconditionally in new_impl#1856
Merged
Conversation
Auth plugin crates with no other reference get stripped by the linker, so their inventory registrations never run and AuthType lookup fails with "not supported" at runtime. The anchor_plugins() workaround existed but had no call site, making it a silent trap for any new consumer of AsyncOpenStack. - call anchor_plugins() from AsyncOpenStack::new_impl, the single constructor both sync and async facades funnel through - drop the now-redundant, never-called _anchor_auth_plugins() in openstack_sdk/src/lib.rs - log discovered auth/multifactor plugin names at debug level for diagnosability Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth plugin crates with no other reference get stripped by the
linker, so their inventory registrations never run and AuthType
lookup fails with "not supported" at runtime. The anchor_plugins()
workaround existed but had no call site, making it a silent trap
for any new consumer of AsyncOpenStack.
constructor both sync and async facades funnel through
openstack_sdk/src/lib.rs
diagnosability
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com