Conversation
- Make SwitchToRegion, CloudChangeScope and ConnectToCloud emit Action::Error instead of panicking when auth or service discovery fails, keeping the worker loop alive. - Broadcast ConnectToCloud, CloudChangeScope, and SwitchToRegion to all registered popups (not just the active one) so they can immediately clear stale data. - Add stale-data clearing to project_select_popup, region_select_popup, home, and generic_resource_view on cloud/scope/region changes. - Emit Action::Regions after ConnectToCloud and CloudChangeScope so the region popup stays in sync. - Guard project_select_popup fetch logic with is_loading and items_fetched to prevent duplicate PerformApiRequest calls on every popup open while guaranteeing a fresh fetch after cloud switches. - Discover service endpoints concurrently using try_join_all. Connect time now depends on the slowest service rather than the sum of all six. TUI_SERVICES constant drives all call sites. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SwitchToRegion, CloudChangeScope and ConnectToCloud emit
Action::Error instead of panicking when auth or service discovery
fails, keeping the worker loop alive.
Broadcast ConnectToCloud, CloudChangeScope, and SwitchToRegion to
all registered popups (not just the active one) so they can
immediately clear stale data.
Add stale-data clearing to project_select_popup, region_select_popup,
home, and generic_resource_view on cloud/scope/region changes.
Emit Action::Regions after ConnectToCloud and CloudChangeScope so
the region popup stays in sync.
Guard project_select_popup fetch logic with is_loading and
items_fetched to prevent duplicate PerformApiRequest calls on every
popup open while guaranteeing a fresh fetch after cloud switches.
Discover service endpoints concurrently using try_join_all.
Connect time now depends on the slowest service rather than the
sum of all six. TUI_SERVICES constant drives all call sites.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com