Skip to content

Put the adaptive site behind a switch - #11212

Merged
sndrs merged 2 commits into
mainfrom
sndrs/adaptive-switch
Apr 19, 2024
Merged

Put the adaptive site behind a switch#11212
sndrs merged 2 commits into
mainfrom
sndrs/adaptive-switch

Conversation

@sndrs

@sndrs sndrs commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this change?

enables switching-off adaptation (added in #11174)

Why?

it changes functionality. if breaks something unexpectedly, we should be able to switch it off

@sndrs
sndrs requested a review from mxdvl April 19, 2024 09:58
@sndrs
sndrs requested a review from a team as a code owner April 19, 2024 09:58
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Apr 19, 2024
@github-actions github-actions Bot added dotcom-rendering and removed run_chromatic Runs chromatic when label is applied labels Apr 19, 2024
@github-actions

github-actions Bot commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Size Change: +15 B (0%)

Total Size: 935 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1225.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/1275.client.web.********************.js 4.83 kB 0 B
dotcom-rendering/dist/1299.client.web.********************.js 926 B 0 B
dotcom-rendering/dist/1411.client.web.********************.js 17.9 kB 0 B
dotcom-rendering/dist/1417.client.web.********************.js 3.61 kB 0 B
dotcom-rendering/dist/2089.client.web.********************.js 3.81 kB 0 B
dotcom-rendering/dist/2111.client.web.********************.js 5.89 kB 0 B
dotcom-rendering/dist/2219.client.web.********************.js 5.86 kB 0 B
dotcom-rendering/dist/2309.client.web.********************.js 2.22 kB 0 B
dotcom-rendering/dist/2342.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/2457.client.web.********************.js 617 B 0 B
dotcom-rendering/dist/2469.client.web.********************.js 2.95 kB 0 B
dotcom-rendering/dist/2471.client.web.********************.js 715 B 0 B
dotcom-rendering/dist/2483.client.web.********************.js 22.4 kB 0 B
dotcom-rendering/dist/2778.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/2975.client.web.********************.js 3.61 kB 0 B
dotcom-rendering/dist/3000.client.web.********************.js 887 B 0 B
dotcom-rendering/dist/3062.client.web.********************.js 2.66 kB 0 B
dotcom-rendering/dist/3114.client.web.********************.js 651 B 0 B
dotcom-rendering/dist/3118.client.web.********************.js 496 B 0 B
dotcom-rendering/dist/3255.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3280.client.web.********************.js 4.81 kB 0 B
dotcom-rendering/dist/3336.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/3494.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/3642.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/3645.client.web.********************.js 440 B 0 B
dotcom-rendering/dist/3893.client.web.********************.js 5.76 kB 0 B
dotcom-rendering/dist/3922.client.web.********************.js 724 B 0 B
dotcom-rendering/dist/3932.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/3945.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/3963.client.web.********************.js 2.81 kB 0 B
dotcom-rendering/dist/4126.client.web.********************.js 158 B 0 B
dotcom-rendering/dist/424.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/440.client.web.********************.js 1.56 kB 0 B
dotcom-rendering/dist/4442.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/4468.client.web.********************.js 3.68 kB 0 B
dotcom-rendering/dist/4516.client.web.********************.js 8.68 kB 0 B
dotcom-rendering/dist/4673.client.web.********************.js 723 B 0 B
dotcom-rendering/dist/4811.client.web.********************.js 994 B 0 B
dotcom-rendering/dist/4850.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/4945.client.web.********************.js 2.92 kB 0 B
dotcom-rendering/dist/5044.client.web.********************.js 802 B 0 B
dotcom-rendering/dist/5084.client.web.********************.js 751 B 0 B
dotcom-rendering/dist/5094.client.web.********************.js 2.98 kB 0 B
dotcom-rendering/dist/5232.client.web.********************.js 527 B 0 B
dotcom-rendering/dist/5238.client.web.********************.js 10.3 kB 0 B
dotcom-rendering/dist/5288.client.web.********************.js 1.85 kB 0 B
dotcom-rendering/dist/5308.client.web.********************.js 2.7 kB 0 B
dotcom-rendering/dist/5310.client.web.********************.js 4.59 kB 0 B
dotcom-rendering/dist/5478.client.web.********************.js 3.46 kB 0 B
dotcom-rendering/dist/5529.client.web.********************.js 12.4 kB 0 B
dotcom-rendering/dist/5578.client.web.********************.js 3.06 kB 0 B
dotcom-rendering/dist/565.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/5671.client.web.********************.js 3.49 kB 0 B
dotcom-rendering/dist/5817.client.web.********************.js 915 B 0 B
dotcom-rendering/dist/5852.client.web.********************.js 530 B 0 B
dotcom-rendering/dist/5998.client.web.********************.js 2.94 kB 0 B
dotcom-rendering/dist/6093.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/6167.client.web.********************.js 640 B 0 B
dotcom-rendering/dist/6277.client.web.********************.js 42.8 kB 0 B
dotcom-rendering/dist/6326.client.web.********************.js 3.13 kB 0 B
dotcom-rendering/dist/6376.client.web.********************.js 3.6 kB 0 B
dotcom-rendering/dist/6381.client.web.********************.js 3.42 kB 0 B
dotcom-rendering/dist/6568.client.web.********************.js 3.8 kB 0 B
dotcom-rendering/dist/6640.client.web.********************.js 906 B 0 B
dotcom-rendering/dist/6709.client.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/6715.client.web.********************.js 4.77 kB 0 B
dotcom-rendering/dist/7061.client.web.********************.js 8.63 kB 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7196.client.web.********************.js 889 B 0 B
dotcom-rendering/dist/72.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/7387.client.web.********************.js 955 B 0 B
dotcom-rendering/dist/7410.client.web.********************.js 6.01 kB 0 B
dotcom-rendering/dist/7723.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/7971.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/8134.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8145.client.web.********************.js 3.14 kB 0 B
dotcom-rendering/dist/8179.client.web.********************.js 825 B 0 B
dotcom-rendering/dist/8183.client.web.********************.js 3.86 kB 0 B
dotcom-rendering/dist/8555.client.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/8565.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/860.client.web.********************.js 8.3 kB 0 B
dotcom-rendering/dist/8754.client.web.********************.js 4.48 kB 0 B
dotcom-rendering/dist/8791.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/889.client.web.********************.js 854 B 0 B
dotcom-rendering/dist/8907.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/9033.client.web.********************.js 2.54 kB 0 B
dotcom-rendering/dist/9060.client.web.********************.js 877 B 0 B
dotcom-rendering/dist/9225.client.web.********************.js 582 B 0 B
dotcom-rendering/dist/9396.client.web.********************.js 680 B 0 B
dotcom-rendering/dist/9430.client.web.********************.js 508 B 0 B
dotcom-rendering/dist/9500.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/9522.client.web.********************.js 3.88 kB 0 B
dotcom-rendering/dist/9527.client.web.********************.js 3 kB 0 B
dotcom-rendering/dist/9696.client.web.********************.js 2.67 kB 0 B
dotcom-rendering/dist/9789.client.web.********************.js 922 B 0 B
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 167 kB 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 423 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.03 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.45 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.6 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.03 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 2.78 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.77 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.78 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.83 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 6.38 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 5.66 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 541 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.27 kB 0 B
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.81 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 3.09 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.67 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.6 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.16 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.43 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 3.35 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 613 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 833 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 343 B 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 3.81 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.8 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 1.66 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.65 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 15 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 9.45 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 12.3 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 47.9 kB +15 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 855 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.1 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.7 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.59 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 2.21 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 435 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.46 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.84 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.95 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 6.63 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.64 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 4.04 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 6.74 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js 4.45 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 4.05 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.66 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 543 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 799 B 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 752 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 539 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 470 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.89 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js 3.64 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 1.99 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 6.76 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js 4.43 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.14 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 768 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.85 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 479 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.52 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 6.98 kB 0 B
dotcom-rendering/dist/SignInGateCustomizableText.client.web.********************.js 955 B 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 1.19 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.53 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 4.52 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.48 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 3.98 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 2.25 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 3.78 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 1.24 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.71 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.65 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 5.47 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 4.11 kB 0 B

compressed-size-action

@github-actions

github-actions Bot commented Apr 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Deploy build 9595 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions

github-actions Bot commented Apr 19, 2024

Copy link
Copy Markdown

Deploy build 33668 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Apr 19, 2024
mxdvl
mxdvl approved these changes Apr 19, 2024
View reviewed changes

@mxdvl mxdvl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout!

Just a quick note to say that the Switchboard still shows this as being an experiment, it should be promoted to a simple switch in Frontend :)

@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Apr 19, 2024
@sndrs

sndrs commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

Good shout!

Just a quick note to say that the Switchboard still shows this as being an experiment, it should be promoted to a simple switch in Frontend :)

sorry yeas, should have linked to guardian/frontend#27066

@sndrs
sndrs merged commit 6e139dc into main Apr 19, 2024
@sndrs
sndrs deleted the sndrs/adaptive-switch branch April 19, 2024 10:23
@prout-bot

prout-bot commented Apr 19, 2024

Copy link
Copy Markdown

Seen on PROD (merged by @sndrs 9 minutes and 43 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mxdvl mxdvl mxdvl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dotcom-rendering Seen-on-PROD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sndrs @prout-bot @mxdvl