Feature Cards: Add gradient mask to background blur - #12902
Merged
Merged
Conversation
jamesmockett
force-pushed
the
jm/feature-card-blur-gradient
branch
from
November 22, 2024 15:22
57a5e27 to
92d47d0
Compare
|
Size Change: +116 B (+0.01%) Total Size: 958 kB
ℹ️ View Unchanged
|
jamesmockett
force-pushed
the
jm/feature-card-blur-gradient
branch
2 times, most recently
from
November 26, 2024 17:30
7fefb29 to
2f1cd5c
Compare
jamesmockett
marked this pull request as ready for review
November 26, 2024 17:41
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
commented
Nov 26, 2024
| padding: ${space[2]}px; | ||
| gap: ${space[1]}px; | ||
| backdrop-filter: blur(12px) brightness(0.7); | ||
| padding: 64px ${space[2]}px ${space[2]}px; |
Contributor
Author
There was a problem hiding this comment.
I've left this as the raw value rather than using space[16] from Source as it ties into the colour stops in the gradient below.
jamesmockett
force-pushed
the
jm/feature-card-blur-gradient
branch
from
November 27, 2024 15:20
2f1cd5c to
8ec7500
Compare
|
Seen on PROD (merged by @jamesmockett 10 minutes ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Masks the background image with a linear gradient so the blur behind the text fades our rather than having a hard edge. A gradient with multiple colour stops is used to approximate a non-linear gradient with an ease-in / ease-out curve, making the transition smoother.
Why?
This makes the effect on web more consistent with the native iOS and Android apps.
Screenshots