Link follow to notifications in article pages - #15558
Merged
Merged
Conversation
aracho1
commented
Mar 19, 2026
| .catch((error) => { | ||
| window.guardian.modules.sentry.reportError( | ||
| error, | ||
| 'bridget-getTagClient-auto-follow-error', |
Contributor
Author
There was a problem hiding this comment.
I've assumed it's ok to create a new Sentry error type for this but please let me know if I should just use an existing one e.g. `'bridget-getTagClient-isFollowing-error'
aracho1
commented
Mar 19, 2026
aracho1
marked this pull request as ready for review
March 19, 2026 11:14
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
JamieB-gu
reviewed
Mar 20, 2026
JamieB-gu
left a comment
Contributor
There was a problem hiding this comment.
Looks good, one question.
aracho1
force-pushed
the
link-follow-to-notifications
branch
from
March 24, 2026 10:39
a24b341 to
fc192bd
Compare
aracho1
force-pushed
the
link-follow-to-notifications
branch
2 times, most recently
from
March 25, 2026 15:58
1fe7ac7 to
fc192bd
Compare
JamieB-gu
approved these changes
Mar 25, 2026
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Why?
We are making a stronger link between follow and notifications, by making users follow something before they can set notifications for the subject.
Screenshots