Add vertical rules to grid module - #15760
Merged
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
force-pushed
the
vertical-rules-for-grid-module
branch
from
April 28, 2026 13:55
5f63f26 to
03f4400
Compare
frederickobrien
force-pushed
the
vertical-rules-for-grid-module
branch
from
April 28, 2026 15:38
03f4400 to
784bb94
Compare
frederickobrien
force-pushed
the
vertical-rules-for-grid-module
branch
from
April 29, 2026 10:19
784bb94 to
2ef3374
Compare
JamieB-gu
reviewed
Apr 30, 2026
JamieB-gu
left a comment
Contributor
There was a problem hiding this comment.
Looks good, a couple of questions.
frederickobrien
force-pushed
the
vertical-rules-for-grid-module
branch
from
April 30, 2026 10:49
2ef3374 to
5abe620
Compare
JamieB-gu
approved these changes
Apr 30, 2026
|
Seen on PROD (merged by @frederickobrien 10 minutes and 16 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Branching off of #15428, this adds a
verticalRulessection to thegridmodule, allowing for lines to be snapped to their appropriate place in the layout. To be set just as the containers are.For the outer lines only:
Or for the central one too:
After a few iterations I made this something that's pure CSS and baked into the grid module itself.
verticalRulesadds outer borders, whileverticalRules({ centre: true })adds an additional one to the left hand side of the centre column.In action over at #15428, which is built on top of this change: