Hide Share button on Hosted Gallery - #16139
Merged
Merged
Conversation
deedeeh
approved these changes
Jun 12, 2026
deedeeh
left a comment
Contributor
There was a problem hiding this comment.
Looks good @dskamiotis 👍🏼
cemms1
reviewed
Jun 15, 2026
| } | ||
| /> | ||
| </Island> | ||
| {shouldIncludeShareButton && ( |
Contributor
There was a problem hiding this comment.
I think it would make sense to put this outside of the div element above it, because at the moment if the share button is omitted you still have the padding-top value, even without anything rendering
|
Seen on PROD (merged by @dskamiotis 9 minutes and 14 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Hides the Share button in image captions for Hosted Gallery, while keeping it visible for non-Hosted Gallery types (including Labs Gallery).
Why?
As part of the Hosted Content redesign, Hosted Gallery pages reuse the Gallery/Labs Gallery body structure, which includes image captions with a Share button.
For Hosted Gallery pages, this caption-level Share button is not required.
This change removes it only for Hosted Gallery and preserves existing behaviour elsewhere.
Note: This is an isolated PR created from branch
cemms1/hosted-galleryso Hosted Gallery behaviour can be tested before that work is in production.The change is intentionally scoped to Hosted Gallery logic only and does not affect current production Labs Gallery behaviour.
Screenshots
Tested on Hosted Gallery using branch
cemms1/hosted-galleryThe current behaviour for Labs Gallery which still need the
sharebutton are successfully unaffected