Adjust grid centre rule clipping - #16141
Merged
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Member
|
A symptom of the bug this PR fixes as raised by @simonbyford : lightbox-weirdness-2.mp4 |
arelra
reviewed
Jun 12, 2026
| */ | ||
| const centreRule = (n: number, color?: string): string => `/* CENTRE RULE */ | ||
| overflow: hidden; | ||
| contain: paint; |
Member
There was a problem hiding this comment.
|
Seen on PROD (merged by @frederickobrien 9 minutes and 28 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug where the
overflow: hiddenproperty applied to containers using the grid module'scentreRule()doesn't play nicely with lightbox. Changing the container propertycontain: paintdoes the trick and is more semantically correct anyway a grid container's vertical rules should stay in their box.