Update frontend cricket match data type to make it in sync with frontend - #16150
Merged
Merged
Conversation
marjisound
force-pushed
the
update-frontend-cricket-data-model
branch
2 times, most recently
from
June 12, 2026 15:34
02a6bd1 to
f86aa49
Compare
marjisound
force-pushed
the
update-frontend-cricket-data-model
branch
3 times, most recently
from
June 12, 2026 15:46
faa589e to
4cd2f1e
Compare
marjisound
marked this pull request as ready for review
June 12, 2026 15:48
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
JamieB-gu
approved these changes
Jun 15, 2026
marjisound
force-pushed
the
update-frontend-cricket-data-model
branch
from
June 16, 2026 09:54
4cd2f1e to
71b31e4
Compare
|
Seen on PROD (merged by @marjisound 11 minutes and 23 seconds ago) Please check your changes! |
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates the frontend cricket match data to make it in sync with the frontend data model change that was done as part of this guardian/frontend#28842
To avoid doing more back and forth, I don't add the field
competitionNameV2which exists in frontend, instead, I continue withcompetitionNamewhich won't be used in PROD until we finish the cricket work. Please read this PR description for more detailsTODO:
Next step is to remove the
competitionNameV2from frontend and instead populatecompetitionNamewith the value ofcompetitionNameV2Fixes part of #15980