Fix emotion template literal minification - #16184
Merged
Merged
Conversation
Jakeii
commented
Jun 17, 2026
| cdk.out | ||
|
|
||
| # SWC cache | ||
| .swc |
Member
Author
There was a problem hiding this comment.
A plugin binary gets cached here
Jakeii
commented
Jun 17, 2026
| "importSource": "@emotion/react" | ||
| } | ||
| }, | ||
| "experimental": { |
Member
Author
There was a problem hiding this comment.
Not sure why it's experimental, I think any wasm plugin is experimental.
Jakeii
marked this pull request as ready for review
June 17, 2026 10:19
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
arelra
approved these changes
Jun 17, 2026
arelra
left a comment
Member
There was a problem hiding this comment.
Amazing spot and fix!
Looks like a ~30% reduction in island size 🥳 🎉
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Add the
@swc/plugin-emotionpluginWhy?
emotioncss using the template literal syntax does not get minified without a babel or swc plugin.Screenshots