Skip to content

Audio player tidying - #16339

Merged
frederickobrien merged 1 commit into
mainfrom
audio-player-tidying
Jul 16, 2026
Merged

frederickobrien merged 1 commit into
mainfrom
audio-player-tidying

Conversation

@frederickobrien

@frederickobrien frederickobrien commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

This extracts some housekeeping from #16133 into its own PR so we don't get things tangled up. Boils down to a rejig of how audio players components are named and nested, plus where the files are kept.

Instead of this:

AudioPlayer.tsx
    AppsAudioPlayer.island.tsx (the apps version)
    AudioPlayerWrapper.island.tsx (the web version)
        AudioPlayer/AudioPlayer.tsx

We get this:

AudioPlayer.tsx
    AudioPlayerApps.island.tsx (the apps version)
    AudioPlayerWeb.island.tsx (the web version)

@frederickobrien frederickobrien self-assigned this Jul 7, 2026
@frederickobrien
frederickobrien requested a review from a team July 7, 2026 16:19
@frederickobrien frederickobrien added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jul 7, 2026
@frederickobrien frederickobrien added this to the Interactives milestone Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions

github-actions Bot commented Jul 7, 2026 •

Copy link
Copy Markdown

@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jul 8, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 8, 2026
@akash1810

akash1810 commented Jul 9, 2026 •

Copy link
Copy Markdown
Member

Please rebase this branch against main before deploying to CODE. #16321 made some changes to CI and infrastructure. Deploying this branch without these changes present will either:

  • Fail when using Riff-Raff's default update strategy
  • OR delete the new infrastructure if using Riff-Raff's "dangerous" mode

Please rebase this branch against main before deploying to CODE.

@github-actions

github-actions Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jul 15, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 15, 2026

@alexduf alexduf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jul 16, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 16, 2026
@frederickobrien
frederickobrien merged commit 8e35d48 into main Jul 16, 2026
30 checks passed
@frederickobrien
frederickobrien deleted the audio-player-tidying branch July 16, 2026 09:32
@gu-prout

gu-prout Bot commented Jul 16, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @frederickobrien 12 minutes and 25 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants