Add preview-* parameter forwarding to SDC requests - #16367
Merged
Merged
Conversation
added 2 commits
July 14, 2026 16:47
…/jm-separate-preview-feature
…nd memoize tagIds in LiveblogGutterAskWrapper
juabara
marked this pull request as ready for review
July 14, 2026 16:28
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
| return; | ||
| } | ||
| const hideSupportMessagingForUser = shouldHideSupportMessaging( | ||
| isSignedIn as boolean, |
Contributor
There was a problem hiding this comment.
hideSupportMessagingForUser is of type: boolean | "Pending". In previous version if it was pending, the function in useEffect returned undefined, no request was sent, but in current implementation request will be sent for hideSupportMessagingForUser == 'Pending" and then one more time, when hideSupportMessagingForUser settles with boolean.
… prevent premature gutter data fetching
AnastasiiaBalenko
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
preview-*URL query parameters to the SDC API alongside existingforce-*parameters. Force takes priority when both are present. Includes preview param support in the SDC package's getModuleData and updates the DCR gutter component to import getGutterLiveblog from the SDC package's main entry point.