Check island locations in CI - #16403
Merged
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
approved these changes
Jul 17, 2026
frederickobrien
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this @arelra, feels like a super worthwhile test
frederickobrien
force-pushed
the
check-islands
branch
from
July 21, 2026 10:30
df3a69f to
9937fb7
Compare
…cation of `src/components` Co-authored-by: GPT-5.4 via GitHub Copilot <github-copilot[bot]@users.noreply.github.com>
frederickobrien
force-pushed
the
check-islands
branch
from
July 22, 2026 08:54
9937fb7 to
83a1b71
Compare
|
Seen on PROD (created by @arelra and merged by @frederickobrien 12 minutes and 38 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: GPT-5.4 via GitHub Copilot <github-copilot[bot]@users.noreply.github.com>
What does this change?
Islands must be located in
src/componentsto ensure webpack has a known location for asynchronous loading.If not followed a runtime error is thrown:
This PR adds a CI check to ensure all islands are in the
src/componentsdirectory.Why?
Earlier feedback.
Fewer errors in production.
How has this change been tested?
Manually.
CI checks on this PR which has not been rebased with #16401
Screenshots