Skip to content

Merge Aa/portrait layout continued into 'portrait layout' - #16482

Merged
frederickobrien merged 45 commits into
portrait-layoutfrom
aa/portrait-layout-continued
Jul 30, 2026
Merged

frederickobrien merged 45 commits into
portrait-layoutfrom
aa/portrait-layout-continued

Conversation

@alessiaAmitrano

Copy link
Copy Markdown
Contributor

What does this change?

Why?

How has this change been tested?

Screenshots

Before After
before after

frederickobrien and others added 30 commits July 2, 2026 15:56
… to top and bottom of headline container, hide stripes above meta
Slim nav, display bylines in the right place, grid adjustments
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@frederickobrien

Copy link
Copy Markdown
Contributor

@copilot rebase this pull request on the latest version of the portrait-layout branch (https://github.com/guardian/dotcom-rendering/tree/portrait-layout)

@frederickobrien frederickobrien self-assigned this Jul 29, 2026
@frederickobrien frederickobrien added the feature Departmental tracking: work on a new feature label Jul 29, 2026
@frederickobrien frederickobrien added this to the Interactives milestone Jul 29, 2026

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@copilot rebase this pull request on the latest version of the portrait-layout branch (https://github.com/guardian/dotcom-rendering/tree/portrait-layout)

The branch already incorporates the latest portrait-layout tip (b31f2dfb59) via the merge commit b1372f66. A true rebase (to produce a clean linear history) requires a force push, which is not available in my tooling — any attempt is rejected and the local state is reset to match the remote.

The code changes are identical to what a rebase would produce. If you'd like to clean up the history with a force push, you'd need to do that manually:

git checkout aa/portrait-layout-continued
git rebase origin/portrait-layout
git push --force-with-lease

Copilot AI review requested due to automatic review settings July 30, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends “immersive” metadata/title rendering so that specific immersive portrait/landscape layout variants can show contributor/avatar/section information, by threading layoutType through the relevant components and updating layout-specific styling.

Changes:

  • Update shouldShowAvatar/shouldShowContributor to consider layoutType for immersive variants, and pass layoutType through meta/title/headline components.
  • Adjust Standard layout grid/styling for immersive portrait/landscape variants and propagate a contentLayoutName value to layout/grid usage.
  • Update Series/Section label behaviour for immersive portrait/landscape variants.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
dotcom-rendering/src/lib/articleMeta.ts Adds layoutType-aware logic for avatar/contributor visibility, especially for immersive variants.
dotcom-rendering/src/lib/articleMeta.test.ts Extends contributor tests with immersive cases.
dotcom-rendering/src/layouts/StandardLayoutArticleGrid.tsx Passes layoutType to title/headline/meta and adjusts immersive grid styling/conditions.
dotcom-rendering/src/layouts/StandardLayout.tsx Introduces contentLayoutName variable, passes it to the grid, and changes MobileStickyContainer rendering.
dotcom-rendering/src/components/SeriesSectionLink.tsx Adds layoutType support to render section link for immersive portrait/landscape variants.
dotcom-rendering/src/components/ArticleTitle.tsx Threads layoutType down into SeriesSectionLink.
dotcom-rendering/src/components/ArticleMeta.web.tsx Uses layoutType to control avatar/contributor display and adjusts immersive meta layout.
dotcom-rendering/src/components/ArticleMeta.apps.tsx Uses layoutType to control avatar/contributor display in Apps meta.
dotcom-rendering/src/components/ArticleHeadline.tsx Adds layoutType prop and derives inverted styling for a specific immersive landscape layout.
Comments suppressed due to low confidence (3)

dotcom-rendering/src/lib/articleMeta.test.ts:78

  • shouldShowContributor now takes layoutType as a second argument; without passing it, this expectation will fail.
		expect(shouldShowContributor(immersivePortraitFeature)).toBe(true);

dotcom-rendering/src/lib/articleMeta.test.ts:82

  • shouldShowContributor now takes layoutType as a second argument; without passing it, this expectation will fail.
		expect(shouldShowContributor(immersiveLandscapeDefault)).toBe(true);

dotcom-rendering/src/lib/articleMeta.test.ts:86

  • shouldShowContributor now takes layoutType as a second argument; without passing it, this expectation will fail.
		expect(shouldShowContributor(immersiveLandscapeFeature)).toBe(true);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

});

it('should return true if Immersive display and immersivePortraitDefault layout', () => {
expect(shouldShowContributor(immersivePortraitDefault)).toBe(true);
Comment thread dotcom-rendering/src/components/ArticleHeadline.tsx Outdated
Comment thread dotcom-rendering/src/layouts/StandardLayout.tsx Outdated
Comment on lines +9 to 13
export const shouldShowAvatar = (
format: ArticleFormat,
layoutType?: LayoutType,
): boolean => {
switch (format.display) {
Comment thread dotcom-rendering/src/layouts/StandardLayoutArticleGrid.tsx
@frederickobrien
frederickobrien force-pushed the aa/portrait-layout-continued branch from b9e37fa to 457487d Compare July 30, 2026 10:17
@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jul 30, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 30, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jul 30, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 30, 2026
@frederickobrien
frederickobrien merged commit 8d18e72 into portrait-layout Jul 30, 2026
21 of 22 checks passed
@frederickobrien
frederickobrien deleted the aa/portrait-layout-continued branch July 30, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants