Add A/B EditorialTest model types to FEFrontCard - #16486
Merged
Merged
Conversation
…recieve a string in the frontend json, not an enum. This can be manually converted later during enhancement if needed.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Fweddi
reviewed
Aug 12, 2026
Fweddi
approved these changes
Aug 12, 2026
abeddow91
force-pushed
the
add-ab-test-model
branch
from
August 13, 2026 09:45
2062f3a to
c608fd4
Compare
emma-imber
approved these changes
Aug 13, 2026
|
Seen on PROD (created by @simonbyford and merged by @abeddow91 7 minutes and 59 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Plumbs the front card Test model, by introducing the an optional
testsfield on FEFrontCard model. As thetestsfield is optional, this change is backwards compatible. TheEditorialTestmodel removes any PII data fields so these are ignored by DCR. At the moment, these are still sent from Frontend but there is a PR in progress to full remove these fields before they are sent to DCR.This PR does not implement editorial testing. This will be achieved in a follow up PR.
Schemas have also been freshly generated to account for these model changes.
Why?
This is required to send editorial a/b test information from frontend to DCR.
How has this change been tested?
Deployed branch to CODE and tested on fronts with and without a tests field. Fronts rendered without issue.