Support headline AB tests on card sublinks - #16709
Open
emma-imber wants to merge 3 commits into
Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d0b30b4fa5d0fd04603fb6bbbe784538bdb38493f5e60090617076714d4c7786"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-ei-support-headline-tests-in-sublinks"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31016"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-95db2811724cad6b71e99d914e97b958179ef026"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
Fweddi
approved these changes
Sep 10, 2026
Fweddi
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Could add some test coverage if we wanted to be extra thorough, but I'd be happy to ship this.
Contributor
Author
Yeah fair shout! Have just pushed a couple of basic tests for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses variant headlines in headline AB tests for sublinks.
Why?
This follows on from this change, which now means we support tests in sublinks in the fronts tool.
How has this change been tested?
Tested locally against a CODE front with an active headline test in a sublink