Skip to content

Support headline AB tests on card sublinks - #16709

Open
emma-imber wants to merge 3 commits into
mainfrom
ei/support-headline-tests-in-sublinks
Open

Support headline AB tests on card sublinks#16709
emma-imber wants to merge 3 commits into
mainfrom
ei/support-headline-tests-in-sublinks

Conversation

@emma-imber

Copy link
Copy Markdown
Contributor

What does this change?

Uses variant headlines in headline AB tests for sublinks.

Why?

This follows on from this change, which now means we support tests in sublinks in the fronts tool.

How has this change been tested?

Tested locally against a CODE front with an active headline test in a sublink

@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@emma-imber emma-imber added the feature Departmental tracking: work on a new feature label Sep 10, 2026
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:d0b30b4fa5d0fd04603fb6bbbe784538bdb38493f5e60090617076714d4c7786

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d0b30b4fa5d0fd04603fb6bbbe784538bdb38493f5e60090617076714d4c7786"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-ei-support-headline-tests-in-sublinks"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31016"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-95db2811724cad6b71e99d914e97b958179ef026"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@abeddow91 abeddow91 added the run_chromatic Runs chromatic when label is applied label Sep 10, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 10, 2026
@emma-imber emma-imber self-assigned this Sep 10, 2026

@Fweddi Fweddi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could add some test coverage if we wanted to be extra thorough, but I'd be happy to ship this.

@emma-imber

Copy link
Copy Markdown
Contributor Author

LGTM! Could add some test coverage if we wanted to be extra thorough, but I'd be happy to ship this.

Yeah fair shout! Have just pushed a couple of basic tests for SupportingContent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature Headline-A|B-Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants