GetMatchStats as an Island - #3815
Merged
Merged
Conversation
oliverlloyd
requested review from
DavidLawes,
OllysCoding,
jlieb10 and
lucymonie
as code owners
January 11, 2022 11:45
|
Size Change: -25 kB (-1%) Total Size: 3.17 MB
ℹ️ View Unchanged
|
OllysCoding
approved these changes
Jan 12, 2022
OllysCoding
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Lets get Loadable out of here!
Contributor
|
This is fantastic. Full steam ahead ⛵ |
Contributor
|
part of #3629 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR moves
GetMatchStatsover to the Island patternWhy?
This is part of thge wider work to migrate away from
App.tsx