Braze - #3923
Closed
oliverlloyd wants to merge 3 commits into
Closed
Braze#3923oliverlloyd wants to merge 3 commits into
Braze#3923oliverlloyd wants to merge 3 commits into
Conversation
oliverlloyd
commented
Feb 4, 2022
| @@ -1,14 +1,12 @@ | |||
| import React, { useState, useEffect } from 'react'; | |||
| import React, { useEffect } from 'react'; | |||
oliverlloyd
commented
Feb 4, 2022
Comment on lines
+42
to
+43
| if (!switches.slotBodyEnd) return false; | ||
| if (!parse(slotMachineFlags || '').showBodyEnd) return false; |
Contributor
Author
There was a problem hiding this comment.
Could somebody please check that this code is the same as:
const showBodyEndSlot =
parse(CAPI.slotMachineFlags || '').showBodyEnd ||
CAPI.config.switches.slotBodyEnd;
This parse function is hard to reason about
Contributor
There was a problem hiding this comment.
The logic looks the same in each case. Your version of splitting into separate conditions is clearer.
bikeshed: A tiny slot-machine-flags.test could be useful.
What is the source of CAPI.slotMachineFlags & CAPI.config.switches?
Contributor
Author
There was a problem hiding this comment.
What is the source of CAPI.slotMachineFlags & CAPI.config.switches?
I'm honestly not sure. I think switches maybe come from a tool around Composer? slotMachineFlags I know nothing about @sndrs any ideas?
|
Size Change: -79.8 kB (-7%) ✅ Total Size: 1.1 MB
ℹ️ View Unchanged
|
tjmw
reviewed
Feb 11, 2022
| } | ||
| } | ||
|
|
||
| export const Braze = ({ |
Member
There was a problem hiding this comment.
Pulling this out of App looks great. I'm not sure Braze is the right name here, as SlotBodyEnd and StickyBottomBanner are broader than just Braze (they may also show epics/banners from RRCP and also the CMP banner). Not sure what a good name is that ties those two slots together though (maybe this is what Automat is 😄 )
Contributor
Author
|
Closing now that we have #4126 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR introduces
Brazea component designed to hold the shared logic betweenSlotBodyEndandStickyBottomBannerWhy?
Because I think this is the safest refactor in order to make progress towards deleting
App.tsx. It probably is possible to isolate each of these components and remove the global state shared between them but this logic is complex and I decided to take this approach as a stepping stone towards this goal instead of diving in.slot-body-endThis id was previously used by the
Portalcomponent as the marker for where to insert the element. But it has also been picked up as an id that can be used for some css styling. By removing thePortalI would break this styling code so I have added anasidewrapper around the component.bannerWrapperThis css previously existed in the
stickinesslib and was added in the layout files. I've moved it down into the banner component directly as this seemed the more logical location for this code.shouldShowSlotBodyEndPreviously we rendered the
SlotBodyEndandStickyBottomBannercomponents independently but they did not always appear together. ForInteractiveandFullPageInteractivearticlesSlotBodyEndis not included and we also checked some flags. This function encapsulates this logic.