MostViewedFooter as an island - #3942
Merged
Merged
Conversation
oliverlloyd
requested review from
a team,
JamieB-gu and
marsavar
as code owners
February 8, 2022 14:41
oliverlloyd
marked this pull request as draft
February 8, 2022 14:44
|
Size Change: -85.4 kB (-6%) ✅ Total Size: 1.24 MB
ℹ️ View Unchanged
|
oliverlloyd
commented
Feb 9, 2022
Comment on lines
+54
to
+56
| switches={{}} | ||
| pageIsSensitive={false} | ||
| isDev={false} |
Contributor
Author
There was a problem hiding this comment.
I''m passing these in to be used by WithABProvider
oliverlloyd
commented
Feb 9, 2022
|
|
||
| import { useApi as useApi_ } from '../../../lib/useApi'; | ||
| import { decidePalette } from '../../../lib/decidePalette'; | ||
| import { useApi as useApi_ } from '../lib/useApi'; |
Contributor
Author
There was a problem hiding this comment.
There's a bunch of these import changes which are merge conflict hangovers
oliverlloyd
marked this pull request as ready for review
February 9, 2022 15:12
jamesgorrie
reviewed
Feb 9, 2022
jamesgorrie
left a comment
Contributor
There was a problem hiding this comment.
Just a question that I think will help me with the review.
| format={format} | ||
| ajaxUrl={ajaxUrl} | ||
| /> | ||
| </WithABProvider> |
Contributor
There was a problem hiding this comment.
Is this reason we need WithABProvider here because this is being loaded in dynamically and so doesn't inherit the BootReact WithABProvider?
Contributor
Author
There was a problem hiding this comment.
Yes, exactly. We're no longer in the same context (the same stack) as BootReact so we need to set our own AB provider
Contributor
There was a problem hiding this comment.
Is this a pattern we will continue to see then and could we look at adding this to the islands code? e.g. All islands have the same as the Boot context?
(another PR / discussion maybe)
Contributor
Author
There was a problem hiding this comment.
I considered this approach (I'll update the PR description to include this) but it turned out to make the inclusion of this AB code dynamic (only when needed/wanted) I would have needed to change the code both in the Island server side component and also the doHydration client side code. It felt like adding more coupling to this for what is a secondary concern wasn't the right thing to do.
The alternative to the dynamic coupling is to just always set it. Which is an option. I guess the discussion is around the trade off between optimisation and dev ex. I think this is a worthwhile discussion to have so I'll raise it 👍
DavidLawes
reviewed
Feb 9, 2022
DavidLawes
reviewed
Feb 10, 2022
DavidLawes
approved these changes
Feb 10, 2022
Contributor
|
🏝️ #3629 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Moves
MostViewedFooterinto an islandWhy?
Less javascript on initial page load
Why
MostViewedFooterLayout?I added this extra component so that we can have something to wrap with
WithABProvider. TheABProvidercomponent must wrap the component that wants to useuseABwhich in this case was happening at the root (inMostViewedFooter) so in this case we needed an extra layer of compositionDo we now need to manually insert
WithABProvider?This code introduces a pattern where we're asking developers to wrap their client side code with
WithABProviderwhere needed. But maybe we can incorporate this into the Islands abstraction itself? See this discussion