Audio atom as an island - #3970
Merged
Merged
Conversation
Contributor
Author
|
Size Change: -78.7 kB (-5%) ✅ Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
OllysCoding
marked this pull request as ready for review
March 14, 2022 11:55
OllysCoding
requested review from
a team,
JamieB-gu,
iainjchambers-guardian and
marsavar
as code owners
March 14, 2022 11:55
2 of 4 tasks
OllysCoding
commented
Mar 14, 2022
| sharedAdTargeting: Record<string, unknown>; | ||
| adUnit: string; | ||
| videoDuration?: number; | ||
| switches: { [key: string]: boolean }; |
Contributor
Author
There was a problem hiding this comment.
AshCorr
reviewed
Mar 14, 2022
oliverlloyd
approved these changes
Mar 14, 2022
AshCorr
approved these changes
Mar 14, 2022
Contributor
|
🏝️ #3629 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds audio atom as an island
Dependant on Frontend passing
switchesto /Blocks request (guardian/frontend#24754)