Revert single front door test - #3982
Merged
Merged
Conversation
marialani
requested review from
a team,
JamieB-gu and
marsavar
as code owners
February 14, 2022 10:27
marialani
marked this pull request as draft
February 14, 2022 10:28
|
Size Change: -237 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
GHaberis
approved these changes
Feb 14, 2022
Contributor
Author
|
Though we have re-added the footer it doesn't appear in the diff of the chromatic UI tests. Presumably this is the expected behaviour as the component is lazy loaded |
Contributor
Interestingly, it started appearing in #4126 🤷 |
Contributor
Author
Well would you look at that 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're now ready to end the Single Front Door test so we can revert these changes.
Reverts #3832