Conversation
|
Size Change: -25.2 kB (-2%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
…ReaderRevenueLinksIsland
AshCorr
force-pushed
the
ash/ReaderRevenueLinksIsland
branch
from
March 3, 2022 16:36
4af59ce to
7d8ad1d
Compare
AshCorr
force-pushed
the
ash/ReaderRevenueLinksIsland
branch
2 times, most recently
from
March 11, 2022 14:33
c4c25ec to
bc081ca
Compare
AshCorr
force-pushed
the
ash/ReaderRevenueLinksIsland
branch
from
March 11, 2022 16:13
bc081ca to
b3b00c9
Compare
AshCorr
commented
Mar 13, 2022
| const { module } = response.data; | ||
| setSupportHeaderResponse(module); | ||
|
|
||
| setAutomat(); |
Member
Author
There was a problem hiding this comment.
There seems to be some kind of race condition happening here which causes rendering the RR banners to ocasionally fail. It seems like for some reason when setAutomat() is called in the App.tsx context it breaks rendering in the Island context, not too sure why.
Seems like the SWR PR is having a similar issue.
AshCorr
marked this pull request as ready for review
March 14, 2022 09:41
AshCorr
requested review from
a team,
JamieB-gu,
iainjchambers-guardian and
marsavar
as code owners
March 14, 2022 09:41
Member
Author
|
Done in #4126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Moves ReaderRevenueLinks to Islands!
Why?
More Islands 💯