fix: remove getCmp - #4174
Closed
mxdvl wants to merge 1 commit into
Closed
fix: remove getCmp#4174mxdvl wants to merge 1 commit into
getCmp#4174mxdvl wants to merge 1 commit into
Conversation
mxdvl
requested review from
a team,
JamieB-gu,
iainjchambers-guardian and
marsavar
as code owners
March 3, 2022 14:53
|
Size Change: -137 kB (-9%) ✅ Total Size: 1.44 MB
ℹ️ View Unchanged
|
oliverlloyd
reviewed
Mar 7, 2022
oliverlloyd
left a comment
Contributor
There was a problem hiding this comment.
In principle, I like this change but as mentioned in standup this PR has some diffs from the Slots work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove
getCmpas it’s not used.Why?
#3924 introduced a pattern we decided we do not really need, which is why #3925 is closed.