Repository navigation
🏝 React Islands: Can we only hydrate selected components? [ON PAUSE UNTIL APRIL] #445
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,25 @@ | ||
| // import compose from 'compose-function'; | ||
| // import createDOMPurify from 'dompurify'; | ||
| // import { JSDOM } from 'jsdom'; | ||
| // import { minify } from 'html-minifier'; | ||
|
|
||
| // We don't represent lists in incopy, so things will just come across with bullet characters. | ||
| // These may also be used for emphasis, so bullet characters don't mean list. | ||
| export const bigBullets = (s: string) => | ||
| s.replace(/•/g, '<span class="bullet">•</span>'); | ||
|
|
||
| // const { window } = new JSDOM(''); | ||
| // const DOMPurify = createDOMPurify(window); | ||
|
|
||
| export const clean: (s: string) => string = s => s; | ||
| // export const clean = compose( | ||
| // // bigBullets, | ||
| // // (s: string) => | ||
| // // minify(s, { | ||
| // // collapseWhitespace: true, | ||
| // // removeEmptyElements: true, | ||
| // // minifyCSS: true, | ||
| // // minifyJS: true, | ||
| // // }), | ||
| // // DOMPurify.sanitize, | ||
| // ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import React from 'react'; | ||
|
|
||
| const ClientComponent: React.FC<{ hello: string }> = ({ hello }) => ( | ||
| <h1>hello frends {hello}</h1> | ||
| ); | ||
| // tslint:disable-next-line: no-default-export | ||
| export default ClientComponent; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // import Loadable from 'react-loadable'; | ||
| import React from 'react'; | ||
|
|
||
| interface IslandProps<P> { | ||
| component: React.ComponentType<P>; | ||
| from: string; | ||
| data: P; | ||
| } | ||
|
|
||
| /** | ||
| * Hydrates a component in the client by async loading the exported component. | ||
| * This does not take children. | ||
| * THE COMPONENT MUST BE A DEFAULT EXPORT FOR NOW. | ||
| * i am aware that this makes me hypocritical | ||
| * | ||
| * @param component - The component as it is exported. | ||
| * @param from - The location of the component in /components. | ||
| * @param data - What you want fed into the component. | ||
| * | ||
| */ | ||
| export const Island: <P>( | ||
| _: IslandProps<P>, | ||
| ) => React.ReactElement<IslandProps<P>> = ({ component, from, data }) => ( | ||
| <div | ||
| className="js-island" | ||
| data-island={from} | ||
| data-data={JSON.stringify(data)} | ||
| > | ||
| {React.createElement(component, data)} | ||
| </div> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use
<gu-island>it looks cooler