Repository navigation
Fix Island performance logs - #5298
Merged
Merged
Conversation
Remove useless and inaccurate measurements in favour of the `duration` property, which is supported in all modern browsers. Fall back to a invalid duration if it was not found.
|
Size Change: -51 B (0%) Total Size: 1.78 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove useless and innaccurate measurements in favour of the
durationproperty, which is supported in all modern browsers.Fall back to a invalid duration (
-1)if it was not found.Why?
The measurements in #5296 were wrong! The dowload time started from time origin.
Screenshots