Skip to content

feat: check array members exist - #5823

Closed
mxdvl wants to merge 1 commit into
mainfrom
mxdvl/no-uncheked-indexed-access/array-checks
Closed

feat: check array members exist#5823
mxdvl wants to merge 1 commit into
mainfrom
mxdvl/no-uncheked-indexed-access/array-checks

Conversation

@mxdvl

@mxdvl mxdvl commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

What does this change?

An alternative to introducing tuple helpers in #5807

Why?

For discussion purposes.

@mxdvl
feat: check array members exist
1660dc9 
An alternative to introducing tuple helpers
@github-actions

github-actions Bot commented Aug 23, 2022

Copy link
Copy Markdown

Size Change: +274 B (0%)

Total Size: 1.64 MB

Filename Size Change
dotcom-rendering/dist/frontend.server.js 491 kB +233 B (0%)
ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1382.legacy.********************.js 5.67 kB 0 B
dotcom-rendering/dist/1815.legacy.********************.js 30.9 kB 0 B
dotcom-rendering/dist/2344.legacy.********************.js 2.78 kB 0 B
dotcom-rendering/dist/259.legacy.********************.js 3.25 kB 0 B
dotcom-rendering/dist/286.********************.js 23.2 kB 0 B
dotcom-rendering/dist/286.legacy.********************.js 23.9 kB 0 B
dotcom-rendering/dist/2947.********************.js 2.74 kB 0 B
dotcom-rendering/dist/2947.legacy.********************.js 2.82 kB 0 B
dotcom-rendering/dist/3210.********************.js 8.58 kB 0 B
dotcom-rendering/dist/3210.legacy.********************.js 9.35 kB 0 B
dotcom-rendering/dist/3307.********************.js 3.12 kB 0 B
dotcom-rendering/dist/3584.********************.js 1.8 kB 0 B
dotcom-rendering/dist/3584.legacy.********************.js 1.8 kB 0 B
dotcom-rendering/dist/4019.********************.js 3.44 kB 0 B
dotcom-rendering/dist/4019.legacy.********************.js 3.48 kB 0 B
dotcom-rendering/dist/5058.********************.js 2.73 kB 0 B
dotcom-rendering/dist/5436.legacy.********************.js 2.68 kB 0 B
dotcom-rendering/dist/5553.********************.js 2.87 kB 0 B
dotcom-rendering/dist/5887.********************.js 5.94 kB 0 B
dotcom-rendering/dist/6101.********************.js 32.9 kB 0 B
dotcom-rendering/dist/6131.********************.js 4.29 kB 0 B
dotcom-rendering/dist/6131.legacy.********************.js 4.3 kB 0 B
dotcom-rendering/dist/6204.********************.js 5.54 kB 0 B
dotcom-rendering/dist/6400.********************.js 21.5 kB 0 B
dotcom-rendering/dist/6400.legacy.********************.js 21.5 kB 0 B
dotcom-rendering/dist/6959.legacy.********************.js 6.46 kB 0 B
dotcom-rendering/dist/7137.legacy.********************.js 6.4 kB 0 B
dotcom-rendering/dist/7148.********************.js 6.8 kB 0 B
dotcom-rendering/dist/7148.legacy.********************.js 7.31 kB 0 B
dotcom-rendering/dist/7576.********************.js 3.96 kB 0 B
dotcom-rendering/dist/7576.legacy.********************.js 5.38 kB 0 B
dotcom-rendering/dist/7800.********************.js 11.3 kB 0 B
dotcom-rendering/dist/7829.********************.js 2.8 kB 0 B
dotcom-rendering/dist/7829.legacy.********************.js 2.91 kB 0 B
dotcom-rendering/dist/7981.********************.js 4.32 kB 0 B
dotcom-rendering/dist/8129.legacy.********************.js 11.8 kB 0 B
dotcom-rendering/dist/8195.legacy.********************.js 2.98 kB 0 B
dotcom-rendering/dist/8414.********************.js 4.37 kB 0 B
dotcom-rendering/dist/8414.legacy.********************.js 4.44 kB 0 B
dotcom-rendering/dist/8471.legacy.********************.js 5.45 kB 0 B
dotcom-rendering/dist/8492.legacy.********************.js 4.41 kB 0 B
dotcom-rendering/dist/8612.********************.js 3.69 kB 0 B
dotcom-rendering/dist/8612.legacy.********************.js 4.18 kB 0 B
dotcom-rendering/dist/8808.********************.js 5.3 kB 0 B
dotcom-rendering/dist/9380.legacy.********************.js 2.83 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.********************.js 4.52 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.legacy.********************.js 4.52 kB 0 B
dotcom-rendering/dist/atomIframe.********************.js 757 B 0 B
dotcom-rendering/dist/atomIframe.legacy.********************.js 806 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.********************.js 459 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.legacy.********************.js 517 B 0 B
dotcom-rendering/dist/bootCmp.********************.js 9.65 kB 0 B
dotcom-rendering/dist/bootCmp.legacy.********************.js 13.3 kB 0 B
dotcom-rendering/dist/Branding-importable.********************.js 4.65 kB 0 B
dotcom-rendering/dist/Branding-importable.legacy.********************.js 4.65 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.********************.js 36.1 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.legacy.********************.js 36.1 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.********************.js 9.44 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.legacy.********************.js 10.1 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.********************.js 4.26 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.legacy.********************.js 4.55 kB 0 B
dotcom-rendering/dist/Carousel-importable.********************.js 11.7 kB 0 B
dotcom-rendering/dist/Carousel-importable.legacy.********************.js 12.2 kB 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.********************.js 261 B 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.legacy.********************.js 271 B 0 B
dotcom-rendering/dist/CommentCount-importable.********************.js 3.46 kB 0 B
dotcom-rendering/dist/CommentCount-importable.legacy.********************.js 3.56 kB 0 B
dotcom-rendering/dist/CommercialMetrics-importable.********************.js 6.47 kB 0 B
dotcom-rendering/dist/CommercialMetrics-importable.legacy.********************.js 810 B 0 B
dotcom-rendering/dist/CoreVitals-importable.********************.js 6.09 kB 0 B
dotcom-rendering/dist/CoreVitals-importable.legacy.********************.js 6.31 kB 0 B
dotcom-rendering/dist/debug.js 1.75 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.********************.js 3.5 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.legacy.********************.js 3.75 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.********************.js 3.94 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.legacy.********************.js 4.05 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.********************.js 2.99 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.legacy.********************.js 3.1 kB 0 B
dotcom-rendering/dist/dynamicImport.********************.js 2 kB 0 B
dotcom-rendering/dist/dynamicImport.legacy.********************.js 2.07 kB 0 B
dotcom-rendering/dist/EditionDropdown-importable.********************.js 4.1 kB 0 B
dotcom-rendering/dist/EditionDropdown-importable.legacy.********************.js 4.15 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.********************.js 3.34 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.legacy.********************.js 3.45 kB 0 B
dotcom-rendering/dist/embedIframe.********************.js 759 B 0 B
dotcom-rendering/dist/embedIframe.legacy.********************.js 810 B 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.********************.js 6.24 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.legacy.********************.js 6.82 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.********************.js 1.73 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.legacy.********************.js 1.78 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.********************.js 2.22 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.legacy.********************.js 2.21 kB 0 B
dotcom-rendering/dist/FilterButton-importable.********************.js 2.64 kB 0 B
dotcom-rendering/dist/FilterButton-importable.legacy.********************.js 2.74 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.********************.js 3.82 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.legacy.********************.js 3.89 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.********************.js 4.71 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.legacy.********************.js 4.77 kB 0 B
dotcom-rendering/dist/ga.********************.js 2.83 kB 0 B
dotcom-rendering/dist/ga.legacy.********************.js 2.9 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.********************.js 4 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.legacy.********************.js 4.18 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.********************.js 9.23 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.legacy.********************.js 9.49 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.********************.js 6.36 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.legacy.********************.js 7.14 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.********************.js 3.08 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.legacy.********************.js 3.24 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.********************.js 11.3 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.js 10.3 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.legacy.********************.js 11.4 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.********************.js 9.28 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.js 9.75 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.********************.js 9.36 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.********************.js 263 B 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.legacy.********************.js 273 B 0 B
dotcom-rendering/dist/initDiscussion.********************.js 11 kB -3 B (0%)
dotcom-rendering/dist/initDiscussion.legacy.********************.js 11.3 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.********************.js 3 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.legacy.********************.js 3.09 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.********************.js 4.26 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.legacy.********************.js 4.43 kB 0 B
dotcom-rendering/dist/islands.********************.js 11.2 kB 0 B
dotcom-rendering/dist/islands.legacy.********************.js 12 kB -5 B (0%)
dotcom-rendering/dist/KeyEventsCarousel-importable.********************.js 2.9 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.legacy.********************.js 3.01 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.********************.js 268 B 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.legacy.********************.js 280 B 0 B
dotcom-rendering/dist/LabsHeader-importable.********************.js 8.66 kB 0 B
dotcom-rendering/dist/LabsHeader-importable.legacy.********************.js 8.79 kB 0 B
dotcom-rendering/dist/Links-importable.********************.js 6.33 kB 0 B
dotcom-rendering/dist/Links-importable.legacy.********************.js 7.39 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.********************.js 6.21 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.legacy.********************.js 6.9 kB 0 B
dotcom-rendering/dist/Liveness-importable.********************.js 3.6 kB +12 B (0%)
dotcom-rendering/dist/Liveness-importable.legacy.********************.js 3.67 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.********************.js 5.11 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.legacy.********************.js 5.34 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.********************.js 7.59 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.legacy.********************.js 7.74 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.********************.js 6.98 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.legacy.********************.js 4.94 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.********************.js 931 B 0 B
dotcom-rendering/dist/newsletterEmbedIframe.legacy.********************.js 975 B 0 B
dotcom-rendering/dist/OnwardsUpper-importable.********************.js 6.78 kB +5 B (0%)
dotcom-rendering/dist/OnwardsUpper-importable.legacy.********************.js 6.99 kB 0 B
dotcom-rendering/dist/ophan.********************.js 7.24 kB 0 B
dotcom-rendering/dist/ophan.legacy.********************.js 7.46 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.********************.js 271 B 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.legacy.********************.js 282 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.********************.js 264 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.legacy.********************.js 274 B 0 B
dotcom-rendering/dist/PulsingDot-importable.********************.js 1.66 kB 0 B
dotcom-rendering/dist/PulsingDot-importable.legacy.********************.js 1.76 kB 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.********************.js 262 B 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.legacy.********************.js 272 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.********************.js 4.58 kB 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.legacy.********************.js 4.6 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.********************.js 3.87 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.js 2.33 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.legacy.********************.js 4.93 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.********************.js 5.87 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.legacy.********************.js 6.27 kB 0 B
dotcom-rendering/dist/relativeTime.********************.js 1.3 kB 0 B
dotcom-rendering/dist/relativeTime.legacy.********************.js 1.35 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.********************.js 5.75 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.legacy.********************.js 5.88 kB +32 B (+1%)
dotcom-rendering/dist/SecureSignupIframe-importable.********************.js 8.43 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.legacy.********************.js 8.76 kB 0 B
dotcom-rendering/dist/sentry.********************.js 684 B 0 B
dotcom-rendering/dist/sentry.legacy.********************.js 691 B 0 B
dotcom-rendering/dist/sentryLoader.********************.js 10.2 kB 0 B
dotcom-rendering/dist/sentryLoader.legacy.********************.js 14.1 kB 0 B
dotcom-rendering/dist/SetABTests-importable.********************.js 8.23 kB 0 B
dotcom-rendering/dist/SetABTests-importable.legacy.********************.js 2.74 kB 0 B
dotcom-rendering/dist/ShareCount-importable.********************.js 3.59 kB 0 B
dotcom-rendering/dist/ShareCount-importable.legacy.********************.js 3.7 kB 0 B
dotcom-rendering/dist/shimport.********************.js 2.78 kB 0 B
dotcom-rendering/dist/shimport.legacy.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.********************.js 726 B 0 B
dotcom-rendering/dist/ShowHideContainers-importable.legacy.********************.js 761 B 0 B
dotcom-rendering/dist/SignInGateMain.********************.js 4.48 kB 0 B
dotcom-rendering/dist/SignInGateMain.js 2.87 kB 0 B
dotcom-rendering/dist/SignInGateMain.legacy.********************.js 4.56 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.********************.js 5.2 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.legacy.********************.js 5.49 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.********************.js 2.29 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.legacy.********************.js 2.93 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.********************.js 5.04 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.legacy.********************.js 5.26 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.********************.js 6.85 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.legacy.********************.js 7.84 kB 0 B
dotcom-rendering/dist/SubNav-importable.********************.js 3.26 kB 0 B
dotcom-rendering/dist/SubNav-importable.legacy.********************.js 3.38 kB 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.********************.js 262 B 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.legacy.********************.js 273 B 0 B
dotcom-rendering/dist/TopicFilterBank-importable.********************.js 3.73 kB 0 B
dotcom-rendering/dist/TopicFilterBank-importable.legacy.********************.js 3.84 kB 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.********************.js 1.99 kB 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.legacy.********************.js 2.02 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.********************.js 1.8 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.legacy.********************.js 1.79 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.********************.js 3.01 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.legacy.********************.js 3.11 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.********************.js 5.13 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.legacy.********************.js 5.35 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.********************.js 2.81 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.legacy.********************.js 2.91 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.********************.js 5.7 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.legacy.********************.js 6 kB 0 B

compressed-size-action

@github-actions

github-actions Bot commented Aug 23, 2022

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR

Lighthouse tested 2 URLs

⚠️ Budget exceeded for 2 of 10 audits.

Report for Article

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left

Category Status Expected Actual
First Contentful Paint ✅ 1500 1261
Largest Contentful Paint ✅ 3000 2194
Time to Interactive ✅ 3500 2354
Cumulative Layout Shift ⚠️ 0.002 0.004428
accessibility ✅ 0.97 0.980000

Report for Front

tested url https://www.theguardian.com/uk

Category Status Expected Actual
First Contentful Paint ✅ 1500 1269
Largest Contentful Paint ✅ 3000 1472
Time to Interactive ✅ 3500 3469
Cumulative Layout Shift ✅ 0.002 0.000000
accessibility ⚠️ 0.97 0.960000

@oliverlloyd oliverlloyd mentioned this pull request Aug 24, 2022
Closed
@mxdvl mxdvl closed this Sep 21, 2022
@mxdvl
mxdvl deleted the mxdvl/no-uncheked-indexed-access/array-checks branch November 11, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dotcom-rendering help wanted question Suggestion 🥒WiP Work in Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mxdvl