Skip to content

refactor(types): FEMediaAtom is singular - #8085

Merged
mxdvl merged 1 commit into
mainfrom
mxdvl/media-atom-singular
Jul 24, 2023
Merged

refactor(types): FEMediaAtom is singular#8085
mxdvl merged 1 commit into
mainfrom
mxdvl/media-atom-singular

Conversation

@mxdvl

@mxdvl mxdvl commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this change?

Rename FEMediaAtom to the singular, as a plural generally indicates an array.

Why?

More consistency!

Discovered in #8075

Screenshots

N/A

@mxdvl mxdvl added the Health label Jun 28, 2023
@mxdvl
mxdvl requested a review from a team as a code owner June 28, 2023 16:22
@github-actions

github-actions Bot commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown

Size Change: +1 B (0%)

Total Size: 635 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1244.modern.********************.js 869 B 0 B
dotcom-rendering/dist/1294.modern.********************.js 5.36 kB 0 B
dotcom-rendering/dist/1321.modern.********************.js 2.29 kB 0 B
dotcom-rendering/dist/1335.modern.********************.js 3.96 kB 0 B
dotcom-rendering/dist/1355.modern.********************.js 3.7 kB 0 B
dotcom-rendering/dist/1465.modern.********************.js 3.31 kB 0 B
dotcom-rendering/dist/1486.modern.********************.js 745 B 0 B
dotcom-rendering/dist/1848.modern.********************.js 644 B 0 B
dotcom-rendering/dist/187.modern.********************.js 3.22 kB 0 B
dotcom-rendering/dist/1948.modern.********************.js 1.88 kB 0 B
dotcom-rendering/dist/1987.modern.********************.js 3.51 kB 0 B
dotcom-rendering/dist/1997.modern.********************.js 745 B 0 B
dotcom-rendering/dist/2071.modern.********************.js 745 B 0 B
dotcom-rendering/dist/2087.modern.********************.js 3.56 kB 0 B
dotcom-rendering/dist/21.modern.********************.js 758 B 0 B
dotcom-rendering/dist/2126.modern.********************.js 885 B 0 B
dotcom-rendering/dist/2201.modern.********************.js 778 B 0 B
dotcom-rendering/dist/2228.modern.********************.js 901 B 0 B
dotcom-rendering/dist/2339.modern.********************.js 779 B 0 B
dotcom-rendering/dist/2494.modern.********************.js 779 B 0 B
dotcom-rendering/dist/275.modern.********************.js 697 B 0 B
dotcom-rendering/dist/3024.modern.********************.js 621 B 0 B
dotcom-rendering/dist/3146.modern.********************.js 6.52 kB 0 B
dotcom-rendering/dist/3239.modern.********************.js 4.89 kB 0 B
dotcom-rendering/dist/3314.modern.********************.js 6.21 kB 0 B
dotcom-rendering/dist/3358.modern.********************.js 638 B 0 B
dotcom-rendering/dist/3549.modern.********************.js 21.3 kB 0 B
dotcom-rendering/dist/356.modern.********************.js 827 B 0 B
dotcom-rendering/dist/3569.modern.********************.js 2.49 kB 0 B
dotcom-rendering/dist/3960.modern.********************.js 619 B 0 B
dotcom-rendering/dist/4113.modern.********************.js 757 B 0 B
dotcom-rendering/dist/4424.modern.********************.js 3.64 kB 0 B
dotcom-rendering/dist/4593.modern.********************.js 1.67 kB 0 B
dotcom-rendering/dist/4734.modern.********************.js 760 B 0 B
dotcom-rendering/dist/4811.modern.********************.js 2.54 kB 0 B
dotcom-rendering/dist/5021.modern.********************.js 963 B 0 B
dotcom-rendering/dist/5071.modern.********************.js 941 B 0 B
dotcom-rendering/dist/5141.modern.********************.js 3.91 kB 0 B
dotcom-rendering/dist/5210.modern.********************.js 632 B 0 B
dotcom-rendering/dist/5251.modern.********************.js 5.28 kB 0 B
dotcom-rendering/dist/533.modern.********************.js 11.9 kB 0 B
dotcom-rendering/dist/5474.modern.********************.js 620 B 0 B
dotcom-rendering/dist/5707.modern.********************.js 2.23 kB 0 B
dotcom-rendering/dist/5974.modern.********************.js 744 B 0 B
dotcom-rendering/dist/6118.modern.********************.js 681 B 0 B
dotcom-rendering/dist/640.modern.********************.js 710 B 0 B
dotcom-rendering/dist/6437.modern.********************.js 867 B 0 B
dotcom-rendering/dist/6534.modern.********************.js 573 B 0 B
dotcom-rendering/dist/6541.modern.********************.js 812 B 0 B
dotcom-rendering/dist/6840.modern.********************.js 4.71 kB 0 B
dotcom-rendering/dist/7039.modern.********************.js 25.8 kB 0 B
dotcom-rendering/dist/7074.modern.********************.js 19 kB 0 B
dotcom-rendering/dist/7133.modern.********************.js 698 B 0 B
dotcom-rendering/dist/7305.modern.********************.js 886 B 0 B
dotcom-rendering/dist/7401.modern.********************.js 689 B 0 B
dotcom-rendering/dist/7569.modern.********************.js 4.55 kB 0 B
dotcom-rendering/dist/7688.modern.********************.js 815 B 0 B
dotcom-rendering/dist/786.modern.********************.js 477 B 0 B
dotcom-rendering/dist/8112.modern.********************.js 3.35 kB 0 B
dotcom-rendering/dist/8165.modern.********************.js 927 B 0 B
dotcom-rendering/dist/8170.modern.********************.js 491 B 0 B
dotcom-rendering/dist/8217.modern.********************.js 4.59 kB 0 B
dotcom-rendering/dist/8268.modern.********************.js 5.5 kB 0 B
dotcom-rendering/dist/836.modern.********************.js 5.2 kB 0 B
dotcom-rendering/dist/8447.modern.********************.js 963 B 0 B
dotcom-rendering/dist/8505.modern.********************.js 556 B 0 B
dotcom-rendering/dist/8555.modern.********************.js 688 B 0 B
dotcom-rendering/dist/8622.modern.********************.js 859 B 0 B
dotcom-rendering/dist/8638.modern.********************.js 834 B 0 B
dotcom-rendering/dist/8834.modern.********************.js 3.53 kB 0 B
dotcom-rendering/dist/9490.modern.********************.js 829 B 0 B
dotcom-rendering/dist/9812.modern.********************.js 2.75 kB 0 B
dotcom-rendering/dist/9906.modern.********************.js 6.27 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.modern.********************.js 411 B 0 B
dotcom-rendering/dist/AnimatePulsingDots-importable.modern.********************.js 387 B 0 B
dotcom-rendering/dist/atomIframe.modern.********************.js 516 B 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.modern.********************.js 3.35 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.modern.********************.js 4.05 kB 0 B
dotcom-rendering/dist/Branding-importable.modern.********************.js 2.19 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.modern.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.modern.********************.js 5.44 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.modern.********************.js 6.47 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.modern.********************.js 6.6 kB 0 B
dotcom-rendering/dist/Carousel-importable.modern.********************.js 6.25 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.modern.********************.js 6.28 kB 0 B
dotcom-rendering/dist/ChartAtomWrapper-importable.modern.********************.js 474 B 0 B
dotcom-rendering/dist/CommentCount-importable.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/discussion.modern.********************.js 394 B 0 B
dotcom-rendering/dist/DiscussionContainer-importable.modern.********************.js 24 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.modern.********************.js 3.8 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.modern.********************.js 2.71 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.modern.********************.js 3.25 kB 0 B
dotcom-rendering/dist/embedIframe.modern.********************.js 518 B 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.modern.********************.js 1.95 kB 0 B
dotcom-rendering/dist/FetchCommentCounts-importable.modern.********************.js 2.98 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.modern.********************.js 1.97 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.modern.********************.js 3.42 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.modern.********************.js 510 B 0 B
dotcom-rendering/dist/frameworks.modern.********************.js 20.8 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.modern.********************.js 3.36 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.modern.********************.js 11.4 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.modern.********************.js 6.35 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.modern.********************.js 2.42 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.modern.********************.js 14 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.modern.********************.js 10.3 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.modern.********************.js 476 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.modern.********************.js 10.8 kB 0 B
dotcom-rendering/dist/index.modern.********************.js 32.6 kB +1 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.modern.********************.js 2.78 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.modern.********************.js 5.8 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.modern.********************.js 4.08 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.modern.********************.js 4.18 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.modern.********************.js 3.04 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtomWrapper-importable.modern.********************.js 482 B 0 B
dotcom-rendering/dist/LatestLinks-importable.modern.********************.js 4.41 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.modern.********************.js 514 B 0 B
dotcom-rendering/dist/LightboxJavascript-importable.modern.********************.js 4.34 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.modern.********************.js 5.13 kB 0 B
dotcom-rendering/dist/Liveness-importable.modern.********************.js 5.53 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.modern.********************.js 4.92 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.modern.********************.js 5.31 kB 0 B
dotcom-rendering/dist/Metrics-importable.modern.********************.js 2.32 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.modern.********************.js 5.36 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.modern.********************.js 7.57 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.modern.********************.js 3.8 kB 0 B
dotcom-rendering/dist/newsletterEmbedIframe.modern.********************.js 621 B 0 B
dotcom-rendering/dist/OnwardsUpper-importable.modern.********************.js 3.54 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtomWrapper-importable.modern.********************.js 482 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.modern.********************.js 479 B 0 B
dotcom-rendering/dist/QandaAtomWrapper-importable.modern.********************.js 476 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.modern.********************.js 460 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.modern.********************.js 3.06 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.modern.********************.js 5.81 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.modern.********************.js 3.26 kB 0 B
dotcom-rendering/dist/relativeTime.modern.********************.js 979 B 0 B
dotcom-rendering/dist/RichLinkComponent-importable.modern.********************.js 5.87 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.modern.********************.js 2.57 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.modern.********************.js 4.37 kB 0 B
dotcom-rendering/dist/sentry.modern.********************.js 766 B 0 B
dotcom-rendering/dist/SetABTests-importable.modern.********************.js 3.75 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.modern.********************.js 535 B 0 B
dotcom-rendering/dist/ShareCount-importable.modern.********************.js 2.92 kB 0 B
dotcom-rendering/dist/shimport.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.modern.********************.js 720 B 0 B
dotcom-rendering/dist/ShowMore-importable.modern.********************.js 5.46 kB 0 B
dotcom-rendering/dist/SignInGateMain.modern.********************.js 2.96 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.modern.********************.js 3.87 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.modern.********************.js 3.67 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.modern.********************.js 2.92 kB 0 B
dotcom-rendering/dist/Snow-importable.modern.********************.js 4.22 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.modern.********************.js 5.16 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.modern.********************.js 3.99 kB 0 B
dotcom-rendering/dist/SubNav-importable.modern.********************.js 2.33 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.modern.********************.js 5.92 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.modern.********************.js 3.08 kB 0 B
dotcom-rendering/dist/TimelineAtomWrapper-importable.modern.********************.js 477 B 0 B
dotcom-rendering/dist/TopRightAdSlot-importable.modern.********************.js 634 B 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.modern.********************.js 1.01 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.modern.********************.js 2.79 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.modern.********************.js 5.33 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.modern.********************.js 2.65 kB 0 B
dotcom-rendering/dist/WeatherData-importable.modern.********************.js 4.88 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.modern.********************.js 953 B 0 B

compressed-size-action

@mxdvl
mxdvl force-pushed the mxdvl/video-atom-in-card branch 9 times, most recently from 6e67b0a to aa56086 Compare June 30, 2023 16:59
@mxdvl
mxdvl force-pushed the mxdvl/media-atom-singular branch 2 times, most recently from b7011c9 to 2376b8d Compare June 30, 2023 17:11
@mxdvl
mxdvl force-pushed the mxdvl/video-atom-in-card branch from aa56086 to 9083883 Compare June 30, 2023 17:15
@mxdvl
mxdvl force-pushed the mxdvl/media-atom-singular branch from 2376b8d to 07d719a Compare June 30, 2023 17:17
@mxdvl
mxdvl force-pushed the mxdvl/video-atom-in-card branch 2 times, most recently from 6757511 to b99c0c0 Compare July 3, 2023 09:03
@mxdvl
mxdvl force-pushed the mxdvl/media-atom-singular branch from 07d719a to 7f2a183 Compare July 3, 2023 13:49
@mxdvl
mxdvl force-pushed the mxdvl/video-atom-in-card branch 8 times, most recently from 9ddf882 to 14f65ea Compare July 5, 2023 15:37
Base automatically changed from mxdvl/video-atom-in-card to main July 5, 2023 16:35
@mxdvl
mxdvl force-pushed the mxdvl/media-atom-singular branch from 7f2a183 to f6d8c45 Compare July 20, 2023 16:43
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Jul 20, 2023
@mxdvl
refactor(types): FEMediaAtom is singular
ae1ce43 
The plural FEMediaAtoms would generally indicate a array,
possibly FEMediaAtom[]
@mxdvl
mxdvl force-pushed the mxdvl/media-atom-singular branch from f6d8c45 to ae1ce43 Compare July 21, 2023 15:44
@mxdvl
mxdvl merged commit 03decf4 into main Jul 24, 2023
@mxdvl
mxdvl deleted the mxdvl/media-atom-singular branch July 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ParisaTork ParisaTork ParisaTork approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dotcom-rendering run_chromatic Runs chromatic when label is applied

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mxdvl @ParisaTork