Repository navigation
Conversation
mxdvl
force-pushed
the
mxdvl/prefer-early-return
branch
from
September 7, 2023 09:10
acd4d98 to
2560fbe
Compare
|
Size Change: 0 B 🆕 Total Size: 0 B |
avoiding nesting helps readability on narrower screens
mxdvl
force-pushed
the
mxdvl/prefer-early-return
branch
from
September 7, 2023 09:39
2560fbe to
d3f778e
Compare
mxdvl
changed the base branch from
main
to
mxdvl/conditional-import-web-vitals
September 7, 2023 09:39
Contributor
Author
if(Date.now() - PR.opened.getTime() > 31_000_000_000) {
return await PR.close();
}
await PR.requestReviews(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Enforces early returns over nested methods via a linting rule.
Why?
Avoiding nesting helps readability on narrower screens.
Currently, there’s 50 instances where we would need to adjust the code should this rule be adopted. This shows a handful of examples of what the changes might look like.
Screenshots
N/A – see 2560fbe