Skip to content

Remove SWR keys from server render - #8976

Closed
mxdvl wants to merge 2 commits into
mainfrom
mxdvl/fix-liveness-on-server
Closed

mxdvl wants to merge 2 commits into
mainfrom
mxdvl/fix-liveness-on-server

Conversation

@mxdvl

@mxdvl mxdvl commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

What does this change?

Make SWR key undefined on the server in Liveness.importable.tsx

Why?

We’re getting error in the catch block on the preview app.

Screenshots

N/A

@github-actions

github-actions Bot commented Oct 3, 2023 •

Copy link
Copy Markdown

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@mxdvl
mxdvl force-pushed the mxdvl/fix-liveness-on-server branch from 20c65dd to edfb8af Compare October 3, 2023 10:59
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Oct 3, 2023
@mxdvl
mxdvl marked this pull request as ready for review October 3, 2023 11:03
@mxdvl
mxdvl requested a review from a team as a code owner October 3, 2023 11:03
run test in Node environment
@mxdvl

mxdvl commented Oct 4, 2023 •

Copy link
Copy Markdown
Contributor Author

Closing in favour of unified approach in #8991

@mxdvl mxdvl closed this Oct 4, 2023
@mxdvl
mxdvl deleted the mxdvl/fix-liveness-on-server branch October 6, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotcom-rendering run_chromatic Runs chromatic when label is applied

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants