Repository navigation
Add ShowcaseLayout for apps - #9013
Merged
Merged
Conversation
|
Size Change: 0 B 🆕 Total Size: 0 B |
Contributor
Author
|
https://github.com/guardian/mobile-apps-api/pull/2713 adds support to MAPI for articles which use the apps |
Contributor
|
Is PS. I really wanted to comment on the unchanged line but we'll have to wait till this one's done! |
ioannakok
approved these changes
Oct 4, 2023
ioannakok
reviewed
Oct 4, 2023
abeddow91
reviewed
Oct 4, 2023
Contributor
Author
@ioannakok I don't think so- I think apps articles don't include any of the web ad slots. We only render that slot in |
This was referenced Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This change adapts the
ShowcaseLayoutfor apps. Generally, apps layouts differ from web in the following ways:showcaselayout.mp4
Closes #8997